Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

memory pool parameter check #1218

Closed
kyungjoo-kim opened this issue Nov 6, 2017 · 0 comments
Closed

memory pool parameter check #1218

kyungjoo-kim opened this issue Nov 6, 2017 · 0 comments
Assignees
@hcedwar
Labels
Enhancement Improve existing capability; will potentially require voting
Milestone
2017 December

Comments

@kyungjoo-kim
Copy link
Contributor

kyungjoo-kim commented Nov 6, 2017 •
edited

Kokkos memory pool needs a certain size relations among capacity, superblock size, min/max block size. These sizes are now checked while allocation is requested but their sanity should be checked in the constructor or parameter set method.

This is an error I encountered. It is my mistake but I was confused even if it reports a correct error message.
trilinos/Trilinos#1935 (comment)
@ibaned ibaned added the Enhancement Improve existing capability; will potentially require voting label Nov 6, 2017
@ibaned ibaned added this to the 2017 December milestone Nov 6, 2017
hcedwar added a commit to hcedwar/kokkos that referenced this issue Nov 30, 2017
@hcedwar
Enrich error message for MemoryPool bounds verification; kokkos#1218
dda5172
@hcedwar hcedwar mentioned this issue Nov 30, 2017
Merged
hcedwar added a commit that referenced this issue Nov 30, 2017
@hcedwar
Merge pull request #1247 from hcedwar/develop
cd62593 
Enrich error message for MemoryPool bounds verification; #1218
@crtrott crtrott closed this as completed Dec 15, 2017
@crtrott crtrott mentioned this issue Dec 15, 2017
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hcedwar hcedwar

Labels
Enhancement Improve existing capability; will potentially require voting
Projects
None yet
Milestone
2017 December
Development

No branches or pull requests
4 participants
@ibaned @kyungjoo-kim @hcedwar @crtrott