Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task dag enhancement. #1354

Closed
kyungjoo-kim opened this issue Jan 23, 2018 · 2 comments
Closed

task dag enhancement. #1354

kyungjoo-kim opened this issue Jan 23, 2018 · 2 comments
Assignees
Labels
Blocks Promotion Overview issue for release-blocking bugs Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) Enhancement Improve existing capability; will potentially require voting
Milestone

Comments

@kyungjoo-kim
Copy link
Contributor

There are missing features in Kokkos task dag capability regarding to CUDA space

  • user interface to set cuda stack size;
  • per team and per thread;
  • user interface to set vector size currently 1x32 is hardwired.

I sent a patch to @hcedwar and this issue is for a tracking purpose.

@hcedwar hcedwar self-assigned this Jan 23, 2018
@hcedwar hcedwar added the Enhancement Improve existing capability; will potentially require voting label Jan 23, 2018
@hcedwar hcedwar added Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) Blocks Promotion Overview issue for release-blocking bugs labels Feb 6, 2018
@hcedwar
Copy link
Contributor

hcedwar commented Feb 6, 2018

@kyungjoo-kim : Integration testing fixes to CUDA back-end

The code is finally working. I need to have kokkos to be updated with the attached patch.
After we fixed capturing the member variables in a class, the error related with "std::move" does not appear anymore and I removed the modification.
The patch includes.

  • memory pool kokkos inline decoration
  • task team member need to have team_barrier() and team_broadcast.
  • I reduced the stack size to default 1024. I tested it and it does not need larger stack anymore (but who knows someday I need it again; so I do not completely remove the interface in the kokkos.

kj-task.patch.txt

@hcedwar hcedwar added this to In Progress in On-node Task DAG Feb 7, 2018
@ibaned ibaned added this to the 2018 February milestone Feb 7, 2018
hcedwar added a commit that referenced this issue Feb 8, 2018
Fixes to enable target library, issue #1354
@kyungjoo-kim
Copy link
Contributor Author

tacho.patch.zip

Oh.... the previous patch miss one thing related to team broadcast. Sorry that I am late for putting this patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocks Promotion Overview issue for release-blocking bugs Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) Enhancement Improve existing capability; will potentially require voting
Projects
No open projects
Development

No branches or pull requests

4 participants