Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ThreadVectorRange with a range #1400

Closed
kyungjoo-kim opened this issue Feb 7, 2018 · 4 comments
Closed

ThreadVectorRange with a range #1400

kyungjoo-kim opened this issue Feb 7, 2018 · 4 comments
Assignees
Labels
Enhancement Improve existing capability; will potentially require voting
Milestone

Comments

@kyungjoo-kim
Copy link
Contributor

I found for TeamThreadRange(member, ibeg, iend) but I could not see ThreadVectorRange(member, ibeg, iend). Do we have a specifc reason not to have that ? If everything is okay, would it be possible to add a constructor with a range arguments (member, begin, end) ?

@crtrott
Copy link
Member

crtrott commented Feb 7, 2018

OK OK we will do it 👎 ...

We didn't have that initially because it is better for the compiler and alignment etc. to have vectorized loops which go from 0 to N. But

  • compilers are getting better
  • too many people ask for this

So we might as well do it.

@kyungjoo-kim
Copy link
Contributor Author

Oh.... I see why you prefer not to have it. Thanks.

I meant to use the ThreadVectorRange on cuda, which can remove unnecessary offset calculation.

Thank you again.

@crtrott
Copy link
Member

crtrott commented Feb 8, 2018

Kyungjoo I totally get it, and I think we should just do it, but document that if possible use the compile time zero offset variant.

@bartgol
Copy link
Contributor

bartgol commented Feb 10, 2018

I just thought I'd need this feature too, and I stumbled on this issue. Any rough idea if/when this could end up in master (or at least develop)? To be clear, I'm not trying to put pressure, I'm just trying to understand if I can wait for this, or if I should find a workaround.

Thanks!

@ibaned ibaned assigned swbova and ndellingwood and unassigned swbova Mar 14, 2018
@ibaned ibaned added this to the 2018 April milestone Mar 14, 2018
@crtrott crtrott added the Enhancement Improve existing capability; will potentially require voting label Mar 21, 2018
ndellingwood added a commit to ndellingwood/kokkos that referenced this issue Apr 23, 2018
Add overload to accept a range and add ctors to
ThreadVectorRangeBoundariesStruct to allow for a starting index.
Address issue kokkos#1400.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improve existing capability; will potentially require voting
Projects
None yet
Development

No branches or pull requests

6 participants