Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check Kokkos::is_initialized in SharedAllocationRecord dtor #1465

Closed
ibaned opened this issue Mar 7, 2018 · 0 comments
Closed

Check Kokkos::is_initialized in SharedAllocationRecord dtor #1465

ibaned opened this issue Mar 7, 2018 · 0 comments
Assignees
@ibaned
Labels
Enhancement Improve existing capability; will potentially require voting
Milestone
2018 April

Comments

@ibaned
Copy link
Contributor

ibaned commented Mar 7, 2018

If this is cheap enough, we should do it even with KOKKOS_DEBUG off. There have been many users who keep allocations around after Kokkos::finalize is called and are bitten by that later on.
@ibaned ibaned added the Enhancement Improve existing capability; will potentially require voting label Mar 7, 2018
@ibaned ibaned added this to the 2018 April milestone Mar 7, 2018
@ibaned ibaned self-assigned this Mar 7, 2018
@ibaned ibaned mentioned this issue Mar 7, 2018
Closed
@ibaned ibaned mentioned this issue Mar 20, 2018
Closed
ibaned added a commit that referenced this issue Mar 21, 2018
@ibaned
Check Kokkos::is_initialized in deallocation
0b8038b 
[#1465]
@ibaned ibaned mentioned this issue Mar 22, 2018
Merged
@ndellingwood ndellingwood mentioned this issue May 25, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ibaned ibaned

Labels
Enhancement Improve existing capability; will potentially require voting
Projects
None yet
Milestone
2018 April
Development

No branches or pull requests
2 participants
@ibaned @ndellingwood