Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Reducers out of Experimental namespace #1494

Closed
ibaned opened this issue Mar 27, 2018 · 2 comments
Closed

Move Reducers out of Experimental namespace #1494

ibaned opened this issue Mar 27, 2018 · 2 comments
Assignees
Labels
Enhancement Improve existing capability; will potentially require voting
Milestone

Comments

@ibaned
Copy link
Contributor

ibaned commented Mar 27, 2018

No description provided.

@ibaned ibaned added Enhancement Improve existing capability; will potentially require voting help wanted labels Mar 27, 2018
@ibaned ibaned added this to the 2018 April milestone Mar 27, 2018
@ibaned ibaned self-assigned this Mar 27, 2018
@dalabre
Copy link
Contributor

dalabre commented Mar 28, 2018

@ibaned This means removing them from ```namespace Experimental { .... }''', thus leaving them in mostly '''namespace Kokkos { }''' ?

....and these are all the reducer functions: md_parallel_for(?), md_parallel_reduce, Sum, Prod, Min, ...etc?

@ibaned
Copy link
Contributor Author

ibaned commented Mar 28, 2018

Yes. You can also add the following to help ease the transition on applications:

namespace Experimental {
  using Kokkos::Min;
  ...
}

This allows Kokkos::Experimental::Min to still compile.

md_parallel_for and md_parallel_reduce are unrelated, in fact they should be removed, but thats @ndellingwood 's responsibility. The reducers are Sum, Prod, Min, etc.

@ibaned ibaned assigned swbova and unassigned ibaned Apr 11, 2018
swbova added a commit to swbova/kokkos that referenced this issue Apr 13, 2018
wrapped 'using' statements in deprecated code block to allow backward
compatibility.
@swbova swbova mentioned this issue Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improve existing capability; will potentially require voting
Projects
None yet
Development

No branches or pull requests

5 participants