Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix View assignment (of managed to unmanaged) #153

Closed
mhoemmen opened this issue Dec 3, 2015 · 5 comments
Closed

Fix View assignment (of managed to unmanaged) #153

mhoemmen opened this issue Dec 3, 2015 · 5 comments
Assignees
@crtrott
Labels
Enhancement Improve existing capability; will potentially require voting
Milestone
Pre Christmas Push

Comments

@mhoemmen
Copy link
Contributor

mhoemmen commented Dec 3, 2015

@crtrott

Assignment of a managed View to an unmanaged View, not with CUDA, updates the unmanaged View's reference count. This causes a thread scalability bottleneck that we observed with ~4 threads in Nalu. Christian knows how to fix this already.

This affects old View, not experimental, but preliminary tests with experimental suggests that it's broken there too.
@crtrott
Copy link
Member

crtrott commented Dec 3, 2015

fixed it for the old view implementation. There are some questions how to do correctly for the new view implementation.

@crtrott crtrott added Enhancement Improve existing capability; will potentially require voting InDevelop labels Dec 3, 2015
@crtrott crtrott added this to the Pre Christmas Push milestone Dec 3, 2015
@crtrott crtrott self-assigned this Dec 3, 2015
@crtrott
Copy link
Member

crtrott commented Dec 3, 2015

Pushed to master

@crtrott crtrott closed this as completed Dec 3, 2015
@mhoemmen
Copy link
Contributor Author

mhoemmen commented Dec 3, 2015

Sweet, thanks Christian!!!

On 12/3/15, 11:22 AM, "Christian Trott" <notifications@github.commailto:notifications@github.com> wrote:

Pushed to master

Reply to this email directly or view it on GitHubhttps://github.com//issues/153#issuecomment-161738229.

@hcedwar hcedwar reopened this Dec 3, 2015
@hcedwar
Copy link
Contributor

hcedwar commented Dec 3, 2015

Also fixed and unit tested in Experimental::View, on the develop branch.

@crtrott
Copy link
Member

crtrott commented Dec 9, 2015

Is now in master and in Trilinos.

@crtrott crtrott closed this as completed Dec 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crtrott crtrott

Labels
Enhancement Improve existing capability; will potentially require voting
Projects
None yet
Milestone
Pre Christmas Push
Development

No branches or pull requests
3 participants
@mhoemmen @hcedwar @crtrott