Kokkos Base Makefile adds AVX to KNC Build

[nmhamster]

If I run: ../generate_makefile.bash --with-openmp --arch=KNC --compiler=which iclc

But use Kokkos files later, I get:

mpiicpc -O3 -I../src -DWITH_MPI=1 -mmic -DCELL_FLUX -I./ -I/home/sdhammo/kokkos/kokkos-git/core/src -I/home/sdhammo/kokkos/kokkos-git/containers/src -I/home/sdhammo/kokkos/kokkos-git/algorithms/src --std=c++11 -mavx -fopenmp -c ../src/Cell.C
icpc: command line error: option '-mavx' not supported

CXXFLAGS looks incorrect here, should be -mmic not -mavx.

[crtrott]

I can't reproduce that at the moment. Can you give more details.
It doesn't look like you are actually building against an installed kokkos?

[nmhamster]

Here is what I have been doing.

(1) git glone ..
(2) cd into directory
(3) mkdir build
(4) cd build
(5) ../generate_makefile.bash --with-openmp --arch=KNC --compiler=which icpc
(6) make

[crtrott]

but where is the -DWITH_MPI coming from? thats not Kokkos.
If you want to first install Kokkos and then build miniaero against the installed directory you need to do
git clone ..
mkdir KokkosBuild
cd KokkosBuild
../generate_makefile.bash --prefix="INSTALLDIR" --with-openmp --arch=KNC --compiler=icpc
make lib
make install

cd MINIAERO/build
make KOKKOS_PATH=INSTALLDIR -j 8

Though I have to admit I didn't try that yet ;-)

[nmhamster]

MiniAero.

[crtrott]

I am going through that right now and will fix any issues ;-)

[crtrott]

OK I just pushed a fix which makes it work at least with GCC. KNC build fails because it says the library is not valid. Is ar the wrong thing to put the things together in that case?
Also the miniAero makefile needs some small changes so that it doesn't override setting from the installed Makefile.kokkos (i.e. comment out some lines):

#Set the path to Kokkos
KOKKOS_PATH = /home/crtrott/KokkosInstall/SNB-OpenMP
#Set the Devices to compile for
#KOKKOS_DEVICES=OpenMP
#Set the Architecture to compiler for
#KOKKOS_ARCH=SNB

(1) ~/kokkos/generate_makefile.bash --with-openmp --prefix=/home/crtrott/KokkosInstall/SNB-OpenMP --arch=SNB --compiler=g++ --kokkos-path=/home/crtrott/kokkos
(2) make install
(3) cd ~/mantevo/trunk/packages/miniAero/miniAero_Kokkos/build/
(4) make -j

that worked for non KNC, for KNC we need to fix the linking step of the library itself I guess.

[nmhamster]

ar should be fine for Kokkos (assuming you want .a file), if not xiar

might be needed from Intel.

Si Hammond

Scalable Computer Architectures
Sandia National Laboratories, NM, USA

On 5/14/15, 5:22 PM, "Christian Trott" notifications@github.com wrote:

OK I just pushed a fix which makes it work at least with GCC. KNC build
fails because it says the library is not valid. Is ar the wrong thing to
put the things together in that case?
Also the miniAero makefile needs some small changes so that it doesn't
override setting from the installed Makefile.kokkos (i.e. comment out
some lines):
#Set the path to Kokkos
KOKKOS_PATH = /home/crtrott/KokkosInstall/SNB-OpenMP
#Set the Devices to compile for
#KOKKOS_DEVICES=OpenMP
#Set the Architecture to compiler for
#KOKKOS_ARCH=SNB
(1) ~/kokkos/generate_makefile.bash --with-openmp
--prefix=/home/crtrott/KokkosInstall/SNB-OpenMP --arch=SNB --compiler=g++
--kokkos-path=/home/crtrott/kokkos
(2) make install
(3) cd ~/mantevo/trunk/packages/miniAero/miniAero_Kokkos/build/
(4) make -j
that worked for non KNC, for KNC we need to fix the linking step of the
library itself I guess.
—
Reply to this email directly or
view it on GitHub
#16 (comment).

[crtrott]

I think this was fixed. If you encounter this issue again feel free to reopen/make a new issue.