Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: use of ballot on Volta #1612

Closed
crtrott opened this issue May 4, 2018 · 3 comments
Closed

Bug: use of ballot on Volta #1612

crtrott opened this issue May 4, 2018 · 3 comments
Assignees
@crtrott
Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Milestone
2018 April

Comments

@crtrott
Copy link
Member

crtrott commented May 4, 2018

Atomic operations on arbitrarily large scalar types can deadlock on Volta if called inside a branching parallel reduce kernel ...

This is caused by use of __ballot(0xFFFFFFF,val) inside the atomic function.
@crtrott crtrott self-assigned this May 4, 2018
@crtrott crtrott added Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) Blocks Promotion Overview issue for release-blocking bugs labels May 4, 2018
@crtrott crtrott added this to the 2018 April milestone May 4, 2018
crtrott added a commit that referenced this issue May 4, 2018
@crtrott
Adding unit test for catching issue #1612
dc19eac
crtrott added a commit that referenced this issue May 4, 2018
@crtrott
Fix for issue #1612
5c25318
@mhoemmen
Copy link
Contributor

mhoemmen commented May 4, 2018

@crtrott Is this why complex<double> sumInto was broken?

@crtrott
Copy link
Member Author

crtrott commented May 5, 2018

Yes that is the reason.

@crtrott crtrott added bug - fix pushed to develop branch and removed Blocks Promotion Overview issue for release-blocking bugs labels May 5, 2018
@mhoemmen mhoemmen mentioned this issue May 5, 2018
Merged
@mhoemmen
Copy link
Contributor

mhoemmen commented May 5, 2018

Thanks @crtrott ! :D

@ndellingwood ndellingwood mentioned this issue May 25, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crtrott crtrott

Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Projects
None yet
Milestone
2018 April
Development

No branches or pull requests
3 participants
@mhoemmen @crtrott @ndellingwood