Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create_mirror_view_and_copy for DynRankView #1651

Closed
kyungjoo-kim opened this issue May 31, 2018 · 3 comments
Closed

create_mirror_view_and_copy for DynRankView #1651

kyungjoo-kim opened this issue May 31, 2018 · 3 comments
Assignees
@ndellingwood
Labels
Enhancement Improve existing capability; will potentially require voting
Milestone
2018 July

Comments

@kyungjoo-kim
Copy link
Contributor

create_mirror_view_and_copy and random function does not take dynrankview.

error: no matching function for call to ‘create_mirror_view_and_copy(Kokkos::DynRankView<double, Kokkos::Serial>&)’
           const auto outputValuesA_Host = Kokkos::create_mirror_view_and_copy(outputValuesA);
/home/kyukim/Work/lib/trilinos/kyukim/packages/kokkos/algorithms/src/Kokkos_Random.hpp:2009:124: error: ‘Rank’ is not a member of ‘Kokkos::DynRankView<double, Kokkos::Serial>’
@ndellingwood ndellingwood added the Enhancement Improve existing capability; will potentially require voting label Jun 4, 2018
@ndellingwood ndellingwood self-assigned this Jun 4, 2018
@ndellingwood ndellingwood added this to the 2018 July milestone Jun 4, 2018
@crtrott
Copy link
Member

crtrott commented Jun 7, 2018

I think Nathan indicated with his self assignment that he is going to fix this ;-)

@ibaned ibaned changed the title some missing things from dynrankview create_mirror_view_and_copy for DynRankView Aug 1, 2018
ndellingwood added a commit that referenced this issue Aug 30, 2018
@ndellingwood
DynRankView: Add create_mirror_view_and_copy routine
92bb470 
Addresses issue #1651
Unit test pattern-matching that for the View's impl added
@ndellingwood ndellingwood mentioned this issue Aug 30, 2018
Merged
@ndellingwood
Copy link
Contributor

PR #1777 issued.

@ndellingwood
Copy link
Contributor

@kyungjoo-kim This is in develop branch now via PR #1777

@crtrott crtrott closed this as completed Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ndellingwood ndellingwood

Labels
Enhancement Improve existing capability; will potentially require voting
Projects
None yet
Milestone
2018 July
Development

No branches or pull requests
3 participants
@kyungjoo-kim @crtrott @ndellingwood