Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid file names on windows #1671

Closed
jrgissing opened this issue Jun 17, 2018 · 5 comments
Closed

invalid file names on windows #1671

jrgissing opened this issue Jun 17, 2018 · 5 comments
Assignees
Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Milestone

Comments

@jrgissing
Copy link

certain file names, e.g. in v2.7.00, appear to use characters that are invalid on Windows machines

this can create issues for certain packages that are also compatible with, or simply wish to be synced to, a Windows machine

e.g. git pulls for the LAMMPS package currently fail on Windows when not excluding the kokkos lib

@crtrott crtrott added the Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) label Jun 18, 2018
@crtrott
Copy link
Member

crtrott commented Jun 18, 2018

Args. can you get output here which demonstrates that. Btw. we should get a windows server up and running this week. We are planning to add (if possible) full windows support with the next release (including for visual studio).

@jrgissing
Copy link
Author

sure, please find that attached. in summary, looks like any file name with a colon is causing the issue

kokkos_lib_invalid_windows_file_names.txt

@mhoemmen
Copy link
Contributor

@csiefer2 may be interested in the above news about Windows testing :)

@ibaned
Copy link
Contributor

ibaned commented Jun 21, 2018

Looks like its basically just the use of colons (:) in the ETI files. The ETI system is up in the air anyways, but if it sticks around for the next release then we should probably just replace :: with _.

@crtrott
Copy link
Member

crtrott commented Jul 2, 2018

Fix in #1677

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Projects
None yet
Development

No branches or pull requests

4 participants