Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reducers min/max_loc test fails randomly due to multiple min values and thus multiple valid locations #1681

Closed
crtrott opened this issue Jul 2, 2018 · 0 comments
Closed

reducers min/max_loc test fails randomly due to multiple min values and thus multiple valid locations #1681

crtrott opened this issue Jul 2, 2018 · 0 comments
Assignees
@crtrott
Labels
Enhancement Improve existing capability; will potentially require voting
Milestone
2018 July

Comments

@crtrott
Copy link
Member

crtrott commented Jul 2, 2018

This was exposed by layoutstride test due to it using srand(time(0)). Our static seeds were just lucky before not to expose the test issue. This is not a bug in Kokkos itself, but just a buggy test.
@crtrott crtrott added the Enhancement Improve existing capability; will potentially require voting label Jul 2, 2018
@crtrott crtrott self-assigned this Jul 2, 2018
crtrott added a commit that referenced this issue Jul 2, 2018
@crtrott
Fix reducers min/max_loc test #1681
c5cd04a
@crtrott crtrott added this to the 2018 July milestone Jul 4, 2018
@crtrott crtrott closed this as completed Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crtrott crtrott

Labels
Enhancement Improve existing capability; will potentially require voting
Projects
None yet
Milestone
2018 July
Development

No branches or pull requests
1 participant
@crtrott