Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem in Kokkos generated cmake file #1770

Closed
jgfouca opened this issue Aug 28, 2018 · 4 comments
Closed

Problem in Kokkos generated cmake file #1770

jgfouca opened this issue Aug 28, 2018 · 4 comments
Assignees
Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)

Comments

@jgfouca
Copy link
Contributor

jgfouca commented Aug 28, 2018

When I build and install kokkos with:

~/kokkos-src/generate_makefile.bash ... --prefix ~/kokkos-install

The generated cmake file:

~/kokkos-install/kokkos_generated_settings.cmake

... has lots and lots of cmake values set to src dir instead of the install dir:

set(KOKKOS_CXXFLAGS -I./ -I/ascldap/users/jgfouca/kokkos-src/core/src ...

It seems like it would be much better to have:

set(KOKKOS_CXXFLAGS -I./ -I/ascldap/users/jgfouca/kokkos-install/include ...

A similar flaw is present in many of the cmake variables in this file.

@jgfouca
Copy link
Contributor Author

jgfouca commented Aug 28, 2018

This problem is also present in cmake-configured build/installs.

@crtrott crtrott added the Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) label Aug 28, 2018
@jgfouca
Copy link
Contributor Author

jgfouca commented Aug 29, 2018

I don't have admin rights to assign myself, but I have agreed to take this issue.

@ndellingwood
Copy link
Contributor

Thanks @jgfouca :)

@jgfouca
Copy link
Contributor Author

jgfouca commented Aug 29, 2018

@ndellingwood , yw! Don't forget #1771

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Projects
None yet
Development

No branches or pull requests

3 participants