Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installed kokkos_generated_settings.cmake contains build directories instead of install directories #1838

Closed
junghans opened this issue Oct 4, 2018 · 6 comments
Labels
Enhancement Improve existing capability; will potentially require voting

Comments

@junghans
Copy link
Contributor

junghans commented Oct 4, 2018

mkdir build
cd build
../kokkos_generate_makefile.bash --prefix=$HOME/kokkos
make
make install
grep "$HOME/kokkos" $HOME/kokkos/kokkos_generated_settings.cmake
@crtrott
Copy link
Member

crtrott commented Oct 5, 2018

Uhm what are you trying to do with that kokkos_generated_settings.cmake file? That is not an executable?

@junghans
Copy link
Contributor Author

junghans commented Oct 5, 2018

Finding and using kokkos in CMake (e.g. https://github.com/ECP-copa/Cabana/blob/master/cmake/FindKOKKOS.cmake), without forcing the user to build Kokkos itself with CMake.

@crtrott
Copy link
Member

crtrott commented Oct 5, 2018

No I mean in your first post did you just mistype and meant kokkos_generate_makefile.bash in line3?

@crtrott
Copy link
Member

crtrott commented Oct 5, 2018

Also was this maybe fixed when we addressed #1770? This is not in master yet but in develop.

@junghans
Copy link
Contributor Author

junghans commented Oct 5, 2018

Copy-paste error!

@ndellingwood
Copy link
Contributor

PR #1840 merged by @crtrott

@ndellingwood ndellingwood added Enhancement Improve existing capability; will potentially require voting InDevelop labels Oct 22, 2018
@crtrott crtrott closed this as completed Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improve existing capability; will potentially require voting
Projects
None yet
Development

No branches or pull requests

3 participants