Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

environment var for ndevices... #1773

Closed
bathmatt opened this issue Aug 29, 2018 · 6 comments
Closed

environment var for ndevices... #1773

bathmatt opened this issue Aug 29, 2018 · 6 comments

Comments

@bathmatt
Copy link

Right now you need to supply --kokkos-ndevice=N to set the number of devices. This can be problematic with cmake and testing, It would be awesome to have an environment var where you can set this.

cmake doesn't have a post exec flag option as far as I can tell, therefore, it isn't easy to set this up.

Thanks
Matt

@crtrott
Copy link
Member

crtrott commented Aug 29, 2018

OK we can look into this. But there is a bigger question to be had. Namely: should we use more environment variables to control runtime behaviour. Prior members of the Kokkos team were very much against it for various reasons, while current folks were generally in favour - we need to go carefully over the reasons why we didn't end up using environment variables before.

@bathmatt
Copy link
Author

I get that, but maybe default to kokkos-ndevices to cuda number devices at least? ctest is a pain w/o this since cmake doesn't really support this use case.

@bathmatt
Copy link
Author

bathmatt commented Sep 5, 2018

Any more thoughts on this?

@ibaned
Copy link
Contributor

ibaned commented Sep 13, 2018

Yesterday's meeting concluded that we should make this available, and basically anything that can be set by an argument should also have an environment variable to control it. We'll throw an error if you try to set it both ways.

@bathmatt
Copy link
Author

bathmatt commented Sep 13, 2018 via email

@crtrott
Copy link
Member

crtrott commented Oct 29, 2018

Tracked in larger #1798

@crtrott crtrott closed this as completed Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants