Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DynRankView: Ctors taking ViewAllocateWithoutInitializing broken #1783

Closed
ndellingwood opened this issue Sep 6, 2018 · 2 comments
Closed

DynRankView: Ctors taking ViewAllocateWithoutInitializing broken #1783

ndellingwood opened this issue Sep 6, 2018 · 2 comments
Assignees
@ndellingwood
Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Milestone
2018 July

Comments

@ndellingwood
Copy link
Contributor

This was exposed by unit tests for recently added create_mirror_view_and_copy functions through Jenkins testing on Apollo with Cuda/9.1 and debug.
@ndellingwood ndellingwood added Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) DevelopOnly labels Sep 6, 2018
@ndellingwood ndellingwood added this to the 2018 July milestone Sep 6, 2018
@ndellingwood ndellingwood self-assigned this Sep 6, 2018
@ndellingwood
Copy link
Contributor Author

I have a fix ready to test, should be in soon.

@ndellingwood ndellingwood added the Blocks Promotion Overview issue for release-blocking bugs label Sep 6, 2018
ndellingwood added a commit that referenced this issue Sep 6, 2018
@ndellingwood
DynRankView: Fix broken ctors, add unit test checks
1f06d5a 
Addresses issue #1783, fixes ctors that take
ViewAllocateWithoutInitializing as first argument.
Extra checks in unit tests to catch the problem.
@ndellingwood ndellingwood mentioned this issue Sep 6, 2018
Merged
@ndellingwood
Copy link
Contributor Author

PR #1784 issued.

@ndellingwood ndellingwood added InDevelop and removed Blocks Promotion Overview issue for release-blocking bugs labels Sep 10, 2018
@crtrott crtrott closed this as completed Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ndellingwood ndellingwood

Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Projects
None yet
Milestone
2018 July
Development

No branches or pull requests
2 participants
@crtrott @ndellingwood