Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FYI: Kokkos build warnings #1786

Closed
dholladay00 opened this issue Sep 6, 2018 · 2 comments
Closed

FYI: Kokkos build warnings #1786

dholladay00 opened this issue Sep 6, 2018 · 2 comments
Assignees
Labels
Enhancement Improve existing capability; will potentially require voting
Milestone

Comments

@dholladay00
Copy link

When compiling kokkos (latest master) with clang 6.0.0 with KOKKOS_ENABLE_COMPILER_WARNINGS=ON, serial execution space only, I get the following warnings:

[ 25%] Building CXX object kokkos/CMakeFiles/kokkos.dir/core/src/impl/Kokkos_Serial_Task.cpp.o
/.../kokkos/core/src/impl/Kokkos_Serial_Task.cpp:63:9: warning: declaration shadows a type
      alias in 'Kokkos::Impl::TaskQueueSpecialization<Kokkos::Serial>' [-Wshadow]
  using execution_space = Kokkos::Serial ;
        ^
/.../kokkos/core/src/impl/Kokkos_Serial_Task.hpp:65:9: note: previous declaration is here
  using execution_space = Kokkos::Serial ;
        ^
/.../kokkos/core/src/impl/Kokkos_Serial_Task.cpp:64:9: warning: declaration shadows a type
      alias in 'Kokkos::Impl::TaskQueueSpecialization<Kokkos::Serial>' [-Wshadow]
  using queue_type      = TaskQueue< execution_space > ;
        ^
/.../kokkos/core/src/impl/Kokkos_Serial_Task.hpp:67:9: note: previous declaration is here
  using queue_type      = Kokkos::Impl::TaskQueue< execution_space > ;
        ^
/.../kokkos/core/src/impl/Kokkos_Serial_Task.cpp:123:9: warning: declaration shadows a type
      alias in 'Kokkos::Impl::TaskQueueSpecialization<Kokkos::Serial>' [-Wshadow]
  using execution_space = Kokkos::Serial ;
        ^
/.../kokkos/core/src/impl/Kokkos_Serial_Task.hpp:65:9: note: previous declaration is here
  using execution_space = Kokkos::Serial ;
        ^
/.../kokkos/core/src/impl/Kokkos_Serial_Task.cpp:124:9: warning: declaration shadows a type
      alias in 'Kokkos::Impl::TaskQueueSpecialization<Kokkos::Serial>' [-Wshadow]
  using queue_type      = TaskQueue< execution_space > ;
        ^
/.../kokkos/core/src/impl/Kokkos_Serial_Task.hpp:67:9: note: previous declaration is here
  using queue_type      = Kokkos::Impl::TaskQueue< execution_space > ;
        ^
4 warnings generated.

This does not have any effect on my use cases (that I know of), just an FYI. Feel free to close.

@crtrott
Copy link
Member

crtrott commented Sep 7, 2018

Weird that this didn't get caught by our test. We will fix that.

@crtrott crtrott self-assigned this Sep 7, 2018
@crtrott crtrott added the Enhancement Improve existing capability; will potentially require voting label Sep 7, 2018
ndellingwood added a commit that referenced this issue Sep 11, 2018
Addresses issue #1786
Rename types triggering -Wshadow warnings.
@ndellingwood
Copy link
Contributor

This started showing up in one of the Mayer nightly tests. PR #1795 issued with renamed types to remove the -Wshadow warnings.

@ibaned ibaned added this to the 2018 July milestone Sep 11, 2018
@crtrott crtrott closed this as completed Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improve existing capability; will potentially require voting
Projects
None yet
Development

No branches or pull requests

4 participants