Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dual_view.view broken with UVM #1834

Closed
ndellingwood opened this issue Oct 3, 2018 · 2 comments
Closed

dual_view.view broken with UVM #1834

ndellingwood opened this issue Oct 3, 2018 · 2 comments
Assignees
@ndellingwood
Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Milestone
2018 September

Comments

@ndellingwood
Copy link
Contributor

This was exposed in Tpetra testing kokkos for promotion with Trilinos.
Solution looks like applying the same fix in PR #1741 used by @crtrott when fixing issue #1659.
@ndellingwood ndellingwood self-assigned this Oct 3, 2018
@ndellingwood ndellingwood added Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) Blocks Promotion Overview issue for release-blocking bugs DevelopOnly labels Oct 3, 2018
@ndellingwood ndellingwood added this to the 2018 September milestone Oct 3, 2018
@ndellingwood
Copy link
Contributor Author

I'll put in a PR shortly.

ndellingwood added a commit that referenced this issue Oct 3, 2018
@ndellingwood
DualView: update static_assert in .view() method
db36844 
Address issue #1834 by pattern matching the memory spaces as done in PR #1741.
@ndellingwood ndellingwood mentioned this issue Oct 3, 2018
Merged
@ndellingwood
Copy link
Contributor Author

PR #1835 issued with potential fix.

@ibaned ibaned added bug - fix pushed to develop branch and removed Blocks Promotion Overview issue for release-blocking bugs labels Oct 4, 2018
@crtrott crtrott closed this as completed Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ndellingwood ndellingwood

Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Projects
None yet
Milestone
2018 September
Development

No branches or pull requests
3 participants
@ibaned @crtrott @ndellingwood