Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nvcc_wrapper should stop immediately if nvcc is not in PATH #1861

Closed
mhoemmen opened this issue Oct 23, 2018 · 1 comment
Closed

nvcc_wrapper should stop immediately if nvcc is not in PATH #1861

mhoemmen opened this issue Oct 23, 2018 · 1 comment
Assignees
@vqd8a
Labels
Enhancement Improve existing capability; will potentially require voting
Milestone
2018 December

Comments

@mhoemmen
Copy link
Contributor

Right now, if nvcc is not in PATH, CMake builds of Kokkos error out around line 98 of kokkos/cmake/kokkos_functions.cmake. That somewhat helpfully says that the compiler is not nvcc or Clang. It would be more helpful for nvcc_wrapper to detect that nvcc (if it wants to use nvcc) is not in PATH.
@crtrott crtrott added the Enhancement Improve existing capability; will potentially require voting label Oct 31, 2018
@vqd8a vqd8a mentioned this issue Nov 7, 2018
Merged
@ibaned ibaned added this to the 2018 December milestone Nov 14, 2018
@ndellingwood
Copy link
Contributor

Looks like this was addressed by PR #1887, merged into develop. May require merge to the nvcc_wrapper repo

@ndellingwood ndellingwood mentioned this issue Feb 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vqd8a vqd8a

Labels
Enhancement Improve existing capability; will potentially require voting
Projects
None yet
Milestone
2018 December
Development

No branches or pull requests
5 participants
@mhoemmen @ibaned @crtrott @ndellingwood @vqd8a