Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kokkos exec space init should init Kokkos profiling #192

Closed
mhoemmen opened this issue Feb 17, 2016 · 0 comments
Closed

Kokkos exec space init should init Kokkos profiling #192

mhoemmen opened this issue Feb 17, 2016 · 0 comments
Assignees
Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) Enhancement Improve existing capability; will potentially require voting
Milestone

Comments

@mhoemmen
Copy link
Contributor

Kokkos::initialize sets up Kokkos profiling. However, the execution spaces' initialize() functions do not. This means that if you call the execution spaces' initialize without calling Kokkos::initialize (as Tpetra does), you don't start Kokkos profiling. It would be reasonable for the execution spaces' initialize() and finalize() functions to start resp. stop Kokkos profiling.

@crtrott @aprokop

@crtrott crtrott added the Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) label Mar 2, 2016
@crtrott crtrott added this to the GTC 2016 milestone Mar 2, 2016
@crtrott crtrott self-assigned this Mar 2, 2016
@crtrott crtrott added the Enhancement Improve existing capability; will potentially require voting label Mar 2, 2016
@hcedwar hcedwar modified the milestones: Spring 2016, GTC 2016 Mar 30, 2016
crtrott added a commit that referenced this issue May 4, 2016
@crtrott crtrott closed this as completed May 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) Enhancement Improve existing capability; will potentially require voting
Projects
None yet
Development

No branches or pull requests

3 participants