Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit_test Makefile is Broken - Recursively Calls itself until Machine Apocalypse. #202

Closed
nmhamster opened this issue Mar 4, 2016 · 5 comments
Assignees
Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Milestone

Comments

@nmhamster
Copy link
Contributor

Seem to be having a problem with the Makefile in unit_test after I run ./generate_makefile.

I clone the Kokkos repo, create a directory for an out of source build, run ../generate_makefile.bash --with-openmp --arch=HSW --compiler=icpc and then run make in unit_test causes infinite recursion.

@nmhamster nmhamster added the Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) label Mar 4, 2016
@crtrott
Copy link
Member

crtrott commented Mar 4, 2016

I can't reproduce that, can you post the output?

@crtrott
Copy link
Member

crtrott commented Mar 4, 2016

Still can't reproduce it. Lets sit down again.

@crtrott crtrott self-assigned this Mar 8, 2016
@crtrott
Copy link
Member

crtrott commented Mar 8, 2016

This was tracked down to previously calling generate_makefile in the Kokkos root directory. That will overwrite the sub makefiles which will end up recursively calling itself if you try to build.

To prevent that generate_makefile should check whether it is called inside of the kokkos root directory.

@nmhamster
Copy link
Contributor Author

I thought we agreed we would modify the generate_makefile.sh to error on this case?

@crtrott
Copy link
Member

crtrott commented Mar 8, 2016

Thats what I meant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Projects
None yet
Development

No branches or pull requests

3 participants