ScatterView LayoutLeft overload currently non-functional

[AndrewGaspar]

The ScatterView constructor for the LayoutLeft variant passes 0 as rank 7 dimension, which makes the View constructor think there's one more dimension than there actually is.

  template <typename RT, typename ... RP >
  ScatterView(View<RT, RP...> const& original_view)
  : unique_token()
  {
    size_t arg_N[8] = {
      original_view.extent(0),
      original_view.extent(1),
      original_view.extent(2),
      original_view.extent(3),
      original_view.extent(4),
      original_view.extent(5),
      original_view.extent(6),
      0
    };
    arg_N[internal_view_type::rank - 1] = unique_token.size();
    internal_view = internal_view_type(
        Kokkos::ViewAllocateWithoutInitializing(
          std::string("duplicated_") + original_view.label()),
        arg_N[0], arg_N[1], arg_N[2], arg_N[3],
        arg_N[4], arg_N[5], arg_N[6], arg_N[7]);
    reset();
  }

Look at the LayoutRight variant for the correct way to do this. Rather than 0, it must be KOKKOS_IMPL_CTOR_DEFAULT_ARG.

[crtrott]

Looks like this error only triggers in debug mode.

[crtrott]

#2169 fixes this.