-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dropping support for Kokkos_{DEVICES,OPTIONS,ARCH} in CMake #2329
Comments
We need to make sure that we keep consistent with the Kokkos Requirements. The Kokkos requirement is there be at least one host execution space. OpenMP with Serial is a legitimate configuration ... However, so is just OpenMP ... Serial should ONLY be enabled if it is explicitly asked for [-DKokkos_ENABLE_SERIAL=ON], or if there is not a host execution space present. Here is an example of how this would look in kokkos_enable_devices.cmake ... IF (NOT KOKKOS_ENABLE_OPENMP) |
@jeffmiles63 Will make sure this behavior is correct. |
I will leave all arch variables as |
We will only support
-DKokkos_ENABLE_FOO=ON
. It means no more two ways to do the same thing. We decided we would rather pay the price of verbosity rather than complexity of the build system.The text was updated successfully, but these errors were encountered: