Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropping support for Kokkos_{DEVICES,OPTIONS,ARCH} in CMake #2329

Closed
dalg24 opened this issue Sep 12, 2019 · 3 comments
Closed

Dropping support for Kokkos_{DEVICES,OPTIONS,ARCH} in CMake #2329

dalg24 opened this issue Sep 12, 2019 · 3 comments
Assignees

Comments

@dalg24
Copy link
Member

dalg24 commented Sep 12, 2019

We will only support -DKokkos_ENABLE_FOO=ON. It means no more two ways to do the same thing. We decided we would rather pay the price of verbosity rather than complexity of the build system.

@jeffmiles63
Copy link
Contributor

We need to make sure that we keep consistent with the Kokkos Requirements. The Kokkos requirement is there be at least one host execution space. OpenMP with Serial is a legitimate configuration ... However, so is just OpenMP ... Serial should ONLY be enabled if it is explicitly asked for [-DKokkos_ENABLE_SERIAL=ON], or if there is not a host execution space present.

Here is an example of how this would look in kokkos_enable_devices.cmake ...
Turn on serial if we cannot find an active host execution space

IF (NOT KOKKOS_ENABLE_OPENMP)
IF (NOT KOKKOS_ENABLE_PTHREAD)
IF (NOT KOKKOS_ENABLE_HPX)
MESSAGE(STATUS "Setting Kokkos_ENABLE_SERIAL=ON because we need a host execution environment")
KOKKOS_DEVICE_OPTION(SERIAL ON "Enable serial backend because no other host backend present")
ENDIF()
ENDIF()
ENDIF()

@jjwilke jjwilke self-assigned this Sep 12, 2019
@jjwilke
Copy link

jjwilke commented Sep 12, 2019

@jeffmiles63 Will make sure this behavior is correct.

@jjwilke
Copy link

jjwilke commented Sep 12, 2019

I will leave all arch variables as Kokkos_ARCH_. We will debate naming on a subsequent PR/issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants