Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing DeepCopy instrumentation in Kokkos #2522

Closed
crtrott opened this issue Oct 31, 2019 · 3 comments
Closed

Missing DeepCopy instrumentation in Kokkos #2522

crtrott opened this issue Oct 31, 2019 · 3 comments
Assignees
@crtrott
Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Projects
Milestone: Release 3.0 Developer: CRTROTT

Comments

@crtrott
Copy link
Member

crtrott commented Oct 31, 2019

Turns out we never call the instrumentation hooks for DeepCopy inside of our deep_copy function ...
@crtrott crtrott added the Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) label Oct 31, 2019
@crtrott crtrott self-assigned this Oct 31, 2019
crtrott added a commit to crtrott/kokkos that referenced this issue Oct 31, 2019
@crtrott
Adding DeepCopy profiling hooks in deep_copy call
bdaa4b1 
addresses issue kokkos#2522
@stanmoore1
Copy link
Contributor

kokkos/kokkos-tools#49

@crtrott crtrott mentioned this issue Oct 31, 2019
Merged
@crtrott
Copy link
Member Author

crtrott commented Oct 31, 2019

Turns out someone did notice it but we ignored the tools issue :-(

@crtrott
Copy link
Member Author

crtrott commented Oct 31, 2019

Anyway PR for fix is issued.

@crtrott crtrott added this to the 3.0 Release milestone Nov 13, 2019
@crtrott crtrott added this to To do in Milestone: Release 3.0 via automation Nov 13, 2019
@crtrott crtrott added this to To do in Developer: CRTROTT via automation Nov 13, 2019
@crtrott crtrott moved this from To do to Done in Milestone: Release 3.0 Nov 13, 2019
@crtrott crtrott moved this from To do to Done in Developer: CRTROTT Nov 13, 2019
@ndellingwood ndellingwood mentioned this issue Jan 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crtrott crtrott

Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Projects
Developer: CRTROTT
  
Done
Milestone: Release 3.0
  
Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@DavidPoliakoff @crtrott @ndellingwood @stanmoore1