Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Alias with Namespace Kokkos:: to Interal Libraries #2530

Closed
lkersting opened this issue Nov 1, 2019 · 2 comments
Closed

Add Alias with Namespace Kokkos:: to Interal Libraries #2530

lkersting opened this issue Nov 1, 2019 · 2 comments

Comments

@lkersting
Copy link
Contributor

Current the internal libraries (e.g. kokkos, kokkoscore, kokkoscontainers, etc.) do not have an alias with the Kokkos namespace (e.g. Kokkos::kokkos, Kokkos::kokkoscore, Kokkos::kokkoscontainers, etc.), but the installed libraries do have the Kokkos namespace.

CMake best practices would be to add an alias to the internal libraries so that all codes reference the Kokkos libraries in the same way (e.g. Kokkos::kokkos) independent on if they are linking to an installed version of Kokkos via find_package(Kokkos) or including Kokkos as a sub directory in their build.

@masterleinad masterleinad added this to the 3.0 Release milestone Nov 4, 2019
@masterleinad masterleinad added this to To do in Milestone: Release 3.0 via automation Nov 4, 2019
jjwilke pushed a commit to jjwilke/kokkos that referenced this issue Nov 13, 2019
@masterleinad
Copy link
Contributor

@lkersting Can you confirm that #2550 works for you?

@lkersting
Copy link
Contributor Author

Yes, these changes fixed the problem. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

4 participants