nvcc_wrapper taking first -std option is counterintuitive

[mdmosby]

The nvcc_wrapper script only uses the first specified -std option which is counter to most compiler behavior of 'last one wins' with duplicate options.

[dalg24]

This was brought up at the developer meeting. We agree that this is counterintuitive and are open to change the behavior.

[mdmosby]

Great! Please let me know if I need to provide any additional information. From: Damien L-G <notifications@github.com> Reply-To: kokkos/kokkos <reply@reply.github.com> Date: Wednesday, December 4, 2019 at 2:18 PM To: kokkos/kokkos <kokkos@noreply.github.com> Cc: "Mosby, Matthew David" <mdmosby@sandia.gov>, Author <author@noreply.github.com> Subject: [EXTERNAL] Re: [kokkos/kokkos] nvcc_wrapper taking first -std option is counterintuitive (#2553) This was brought up at the developer meeting. We agree that this is counterintuitive and are open to change the behavior. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#2553?email_source=notifications&email_token=AKQH7MXSSCDVKSJ7ZJMAMATQXANA3A5CNFSM4JN5W5J2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF6QUHQ#issuecomment-561842718>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKQH7MRS47F5JENEUPTHJ3DQXANA3ANCNFSM4JN5W5JQ>.

[jjwilke]

We are working to address this. For reference, can you give a bit more detail on how you configured such that you ended up with two -std flags?

[mdmosby]

I am experimenting with a new library in SNL’s Sierra engineering code and it needed to compile certain files with –std=c++14. The build system just appended it to the build line for the relevant objects. As every other compiler we use takes the last conflicting option, this is not an issue. From: Jeremy <notifications@github.com> Reply-To: kokkos/kokkos <reply@reply.github.com> Date: Thursday, December 5, 2019 at 9:28 AM To: kokkos/kokkos <kokkos@noreply.github.com> Cc: "Mosby, Matthew David" <mdmosby@sandia.gov>, Author <author@noreply.github.com> Subject: [EXTERNAL] Re: [kokkos/kokkos] nvcc_wrapper taking first -std option is counterintuitive (#2553) We are working to address this. For reference, can you give a bit more detail on how you configured such that you ended up with two -std flags? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#2553?email_source=notifications&email_token=AKQH7MVLETJQHHWA6QJKUVDQXETZTA5CNFSM4JN5W5J2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGBJFAI#issuecomment-562205313>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKQH7MTNRDNO5EMTVEJFH2LQXETZTANCNFSM4JN5W5JQ>.

[jjwilke]

Is this CMake? Or Makefiles?

[mdmosby]

The Sierra build system uses bjam to construct make/ninja files. The behavior of the build system is to append compiler options whenever they are different from the defaults, e.g., specified on the command line. From: Jeremy <notifications@github.com> Reply-To: kokkos/kokkos <reply@reply.github.com> Date: Thursday, December 5, 2019 at 2:36 PM To: kokkos/kokkos <kokkos@noreply.github.com> Cc: "Mosby, Matthew David" <mdmosby@sandia.gov>, Author <author@noreply.github.com> Subject: [EXTERNAL] Re: [kokkos/kokkos] nvcc_wrapper taking first -std option is counterintuitive (#2553) Is this CMake? Or Makefiles? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#2553?email_source=notifications&email_token=AKQH7MT5NF5SLWUSV6Z5VELQXFX4PA5CNFSM4JN5W5J2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGCHM3I#issuecomment-562329197>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKQH7MT76RN3VZGMQFXRAHTQXFX4PANCNFSM4JN5W5JQ>.

[ndellingwood]

Looks like this was addressed by PR #2580