Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename View::memory_span to View::required_allocation_size #256

Closed
hcedwar opened this issue Apr 27, 2016 · 1 comment
Closed

Rename View::memory_span to View::required_allocation_size #256

hcedwar opened this issue Apr 27, 2016 · 1 comment
Assignees
Labels
Enhancement Improve existing capability; will potentially require voting
Milestone

Comments

@hcedwar
Copy link
Contributor

hcedwar commented Apr 27, 2016

The name of this member function has been a reoccurring source of confusion, as such a rename is warranted.

@hcedwar hcedwar added the Enhancement Improve existing capability; will potentially require voting label Apr 27, 2016
@hcedwar hcedwar added this to the Spring 2016 milestone Apr 27, 2016
@crtrott
Copy link
Member

crtrott commented Apr 27, 2016

Here are all the current occurrences:

/home/crtrott/Trilinos/packages/kokkos/core/src/impl/KokkosExp_ViewMapping.hpp:  KOKKOS_INLINE_FUNCTION constexpr size_t memory_span() const
/home/crtrott/Trilinos/packages/kokkos/core/src/impl/KokkosExp_ViewMapping.hpp:  static constexpr size_t memory_span( typename Traits::array_layout const & arg_layout )
/home/crtrott/Trilinos/packages/kokkos/core/src/impl/KokkosExp_ViewArray.hpp:  KOKKOS_INLINE_FUNCTION constexpr size_t memory_span() const
/home/crtrott/Trilinos/packages/kokkos/core/src/KokkosExp_View.hpp:  static constexpr size_t memory_span( const size_t arg_N0 = 0
/home/crtrott/Trilinos/packages/kokkos/core/src/KokkosExp_View.hpp:      return map_type::memory_span(
/home/crtrott/Trilinos/packages/kokkos/core/src/KokkosExp_View.hpp:    return map_type::memory_span(
/home/crtrott/Trilinos/packages/kokkos/core/src/KokkosExp_View.hpp:                arg_space.get_shmem( map_type::memory_span( arg_layout ) ) ) )
/home/crtrott/Trilinos/packages/kokkos/core/src/KokkosExp_View.hpp:                  map_type::memory_span(
/home/crtrott/Trilinos/packages/sacado/src/KokkosExp_View_Fad.hpp:  static constexpr size_t memory_span( typename Traits::array_layout const & layout )
/home/crtrott/Trilinos/packages/stokhos/src/sacado/kokkos/pce/KokkosExp_View_UQ_PCE_Contiguous.hpp:  memory_span(const size_t span, const unsigned pce_size) {
/home/crtrott/Trilinos/packages/stokhos/src/sacado/kokkos/pce/KokkosExp_View_UQ_PCE_Contiguous.hpp:  static size_t memory_span( typename Traits::array_layout const & layout )
/home/crtrott/Trilinos/packages/stokhos/src/sacado/kokkos/pce/KokkosExp_View_UQ_PCE_Contiguous.hpp:      return handle_type::memory_span( offset.span(), sacado_size );
/home/crtrott/Trilinos/packages/stokhos/src/sacado/kokkos/pce/KokkosExp_View_UQ_PCE_Contiguous.hpp:      handle_type::memory_span( m_offset.span(), m_sacado_size );
/home/crtrott/Trilinos/packages/stokhos/src/sacado/kokkos/vector/KokkosExp_View_MP_Vector_Contiguous.hpp:  memory_span(const size_t span, const unsigned vector_size) {
/home/crtrott/Trilinos/packages/stokhos/src/sacado/kokkos/vector/KokkosExp_View_MP_Vector_Contiguous.hpp:  memory_span(const size_t span, const unsigned vector_size) {
/home/crtrott/Trilinos/packages/stokhos/src/sacado/kokkos/vector/KokkosExp_View_MP_Vector_Contiguous.hpp:  static size_t memory_span( typename Traits::array_layout const & layout )
/home/crtrott/Trilinos/packages/stokhos/src/sacado/kokkos/vector/KokkosExp_View_MP_Vector_Contiguous.hpp:      return handle_type::memory_span( offset.span(), sacado_size.value );
/home/crtrott/Trilinos/packages/stokhos/src/sacado/kokkos/vector/KokkosExp_View_MP_Vector_Contiguous.hpp:      handle_type::memory_span( m_offset.span(), m_sacado_size.value );

@crtrott crtrott self-assigned this Apr 27, 2016
crtrott added a commit that referenced this issue May 5, 2016
@crtrott crtrott closed this as completed May 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improve existing capability; will potentially require voting
Projects
None yet
Development

No branches or pull requests

2 participants