Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old View and its infrastructure #259

Closed
hcedwar opened this issue Apr 27, 2016 · 6 comments
Closed

Remove old View and its infrastructure #259

hcedwar opened this issue Apr 27, 2016 · 6 comments
Assignees
Labels
Enhancement Improve existing capability; will potentially require voting
Milestone

Comments

@hcedwar
Copy link
Contributor

hcedwar commented Apr 27, 2016

Given a sufficient period of use for the new View, remove the old Kokkos::View and its implementation infrastructure and move the new Kokkos::Experimental::View and its implementation infrastructure into the appropriate Kokkos and Kokkos::Impl namespaces.

@hcedwar hcedwar added the Enhancement Improve existing capability; will potentially require voting label Apr 27, 2016
@hcedwar hcedwar added this to the Backlog milestone Apr 27, 2016
@dsunder
Copy link
Contributor

dsunder commented Apr 27, 2016

Great job!

On Apr 27, 2016, at 15:21, hcedwar notifications@github.com wrote:

Given a sufficient period of use for the new View, remove the old Kokkos::View and its implementation infrastructure and move the new Kokkos::Experimental::View and its implementation infrastructure into the appropriate Kokkos and Kokkos::Impl namespaces.


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub

@hcedwar hcedwar modified the milestones: Summer 2016, Backlog Jul 28, 2016
@hcedwar hcedwar self-assigned this Jul 28, 2016
@hcedwar
Copy link
Contributor Author

hcedwar commented Aug 10, 2016

Old View removed in commit:
e17ea00

Pending to move from Kokkos::Experimental to Kokkos namespace. Must schedule with downstream users to avoid potential breakage.

@hcedwar
Copy link
Contributor Author

hcedwar commented Aug 17, 2016

Postpone namespace move until Trilinos packages update to use non-experimental namespace.

@hcedwar hcedwar modified the milestones: Backlog, Summer 2016 Aug 17, 2016
@rppawlo
Copy link
Contributor

rppawlo commented Aug 17, 2016

Do you know which packages are still using the experimental namespace?

@hcedwar hcedwar modified the milestones: Fall 2016, Backlog Sep 28, 2016
@hcedwar
Copy link
Contributor Author

hcedwar commented Sep 29, 2016

Removed dead code.
Moved all but ViewMapping, ViewArrayAnalysis, and ViewDataAnalysis from namespace Kokkos::Experimental::Impl to Kokkos::Impl. Moving these requires coordination with downstream code that specializes ViewMapping for non-trival scalar types.

Final completion is issue #462

@hcedwar
Copy link
Contributor Author

hcedwar commented Oct 5, 2016

Remove use of
KOKKOS_USING_DEPRECATED_VIEW
KOKKOS_USING_EXPERIMENTAL_VIEW
KOKKOS_USING_EXP_VIEW

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improve existing capability; will potentially require voting
Projects
None yet
Development

No branches or pull requests

4 participants