Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate_makefile.bash should allow tests to be disabled #2886

Closed
jeffhammond opened this issue Mar 17, 2020 · 4 comments
Closed

generate_makefile.bash should allow tests to be disabled #2886

jeffhammond opened this issue Mar 17, 2020 · 4 comments
Labels
Enhancement Improve existing capability; will potentially require voting

Comments

@jeffhammond
Copy link

jeffhammond commented Mar 17, 2020

generate_makefile.bash enables tests unconditionally, unlike the examples. I build Kokkos in Travis CI and do not want to waste time etc. on stuff I don't need.

This is a trivial fix and I will eventually attempt to contribute the patch.

generate_makefile.bash:echo cmake $COMPILER_CMD  -DCMAKE_CXX_FLAGS="${KOKKOS_CXXFLAGS}" -DCMAKE_EXE_LINKER_FLAGS="${KOKKOS_LDFLAGS}" -DCMAKE_INSTALL_PREFIX=${PREFIX} ${KOKKOS_DEVICE_CMD} ${KOKKOS_ARCH_CMD} -DKokkos_ENABLE_TESTS=ON -DKokkos_ENABLE_EXAMPLES=${KOKKOS_DO_EXAMPLES} ${KOKKOS_OPTION_CMD} ${KOKKOS_CUDA_OPTION_CMD} -DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_CXX_EXTENSIONS=OFF ${STANDARD_CMD} ${KOKKOS_DEBUG_CMD} ${KOKKOS_HWLOC_CMD} ${KOKKOS_HWLOC_PATH_CMD} ${KOKKOS_MEMKIND_CMD} ${KOKKOS_MEMKIND_PATH_CMD} ${KOKKOS_PATH}
generate_makefile.bash:cmake $COMPILER_CMD  -DCMAKE_CXX_FLAGS="${KOKKOS_CXXFLAGS//\"}" -DCMAKE_EXE_LINKER_FLAGS="${KOKKOS_LDFLAGS//\"}" -DCMAKE_INSTALL_PREFIX=${PREFIX} ${KOKKOS_DEVICE_CMD} ${KOKKOS_ARCH_CMD} -DKokkos_ENABLE_TESTS=ON -DKokkos_ENABLE_EXAMPLES=${KOKKOS_DO_EXAMPLES} ${KOKKOS_OPTION_CMD} ${KOKKOS_CUDA_OPTION_CMD} -DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_CXX_EXTENSIONS=OFF ${STANDARD_CMD} ${KOKKOS_DEBUG_CMD} ${KOKKOS_HWLOC_CMD} ${KOKKOS_HWLOC_PATH_CMD} ${KOKKOS_MEMKIND_CMD} ${KOKKOS_MEMKIND_PATH_CMD} ${KOKKOS_PATH}
@crtrott
Copy link
Member

crtrott commented Mar 17, 2020

Ah we should just take the file out of the main directory. Or do you really find it so useful? It is actually just intended as a shortcut for our testing.

@jeffhammond
Copy link
Author

@crtrott I really like it because I hate CMake so much.

@ndellingwood
Copy link
Contributor

@jeffhammond I can put in PR in a few minutes with the changes you requested

@ndellingwood
Copy link
Contributor

PR #2887 adds option --disable-tests to generate_makefile.bash

@crtrott crtrott added Enhancement Improve existing capability; will potentially require voting InDevelop labels Mar 18, 2020
@crtrott crtrott closed this as completed Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improve existing capability; will potentially require voting
Projects
None yet
Development

No branches or pull requests

3 participants