Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DualView sync_device with length zero creates cuda errors #2946

Closed
crtrott opened this issue Apr 9, 2020 · 0 comments
Closed

DualView sync_device with length zero creates cuda errors #2946

crtrott opened this issue Apr 9, 2020 · 0 comments
Assignees
@crtrott
Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)

Comments

@crtrott
Copy link
Member

crtrott commented Apr 9, 2020

The prefetch I added doesn't work with a null ptr (the cuda function says a nullptr is an invalid argument). This makes DualView sync_device with a default constructed DualView in UVM memory create errors. I am adding a unit test for that and fix the issue.
@crtrott crtrott added Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) Blocks Promotion Overview issue for release-blocking bugs DevelopOnly labels Apr 9, 2020
@crtrott crtrott self-assigned this Apr 9, 2020
crtrott added a commit to crtrott/kokkos that referenced this issue Apr 9, 2020
@crtrott
Fixes DUalView UVM wiht zero lenght sync
ce91154 
Addresses issue kokkos#2946
@crtrott crtrott added InDevelop and removed Blocks Promotion Overview issue for release-blocking bugs labels Apr 14, 2020
@crtrott crtrott closed this as completed Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crtrott crtrott

Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@crtrott