Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tutorials to track new Kokkos::View #323

Closed
ambrad opened this issue Jun 8, 2016 · 9 comments
Closed

Fix tutorials to track new Kokkos::View #323

ambrad opened this issue Jun 8, 2016 · 9 comments
Assignees
Labels
Feature Request Create new capability; will potentially require voting
Milestone

Comments

@ambrad
Copy link

ambrad commented Jun 8, 2016

I think one or more of the tutorials need a few changes to track the new Kokkos::View. 04_dualviews uses array_intrinsic_type, for example.

@ndellingwood
Copy link
Contributor

@ambrad Thanks for pointing that out, I checked with Carter and the tutorials need to be added to the testing. Marking this as feature request. @hcedwar @crtrott

I'm guessing you fixed the issue, but for issue reference array_intrinsic_type should be replaced by scalar_array_type

I built the tutorials on my laptop (clang compiler) and on kokkos-dev with cuda and did not have other build errors.

@ndellingwood ndellingwood added the Feature Request Create new capability; will potentially require voting label Jun 8, 2016
@ndellingwood ndellingwood added this to the Summer 2016 milestone Jun 8, 2016
@ambrad
Copy link
Author

ambrad commented Jun 8, 2016

Great, thanks! Yes, I switched the types and also seemed to have to write Kokkos::Impl::Timer instead of Kokkos::Timer.

@ndellingwood
Copy link
Contributor

ndellingwood commented Jun 8, 2016

Another note, the most recent tutorial with learning materials (slides, codes) is available at [(https://github.com/kokkos/kokkos-tutorials)]

@ndellingwood
Copy link
Contributor

@ambrad Was that in the same example (04_dualviews) where you had the issue with the timer? I wasn't able to replicate.

@ndellingwood
Copy link
Contributor

I also had runtime errors when running the cuda build of that example that need fixing.

[ndellin@kokkos-dev 04_dualviews]$ ./dual_view.cuda 
Device Time with Sync: 0.073874 without Sync: 0.003030 
Host   Time with Sync: 0.497851 without Sync: 0.495363 
Kokkos::Cuda::Cuda instance constructor : ERROR device not initialized

@ambrad
Copy link
Author

ambrad commented Jun 9, 2016

You are right about Timer; sorry for the false alarm.

@ndellingwood
Copy link
Contributor

@ambrad
Bug fixes for tutorials in pull request #328 (a fix for the DynRankView performance test also squashed in there).
All tutorials now pass with Cuda 7.5.18.
Makefile paths are updated to nvcc_wrapper (i.e. ../../etc./config/nvcc_wrapper Cuda builds only)
Thanks @crtrott and @hcedwar !

@hcedwar
Copy link
Contributor

hcedwar commented Jun 15, 2016

Add these to the nightly build

@ndellingwood ndellingwood self-assigned this Jun 29, 2016
@hcedwar
Copy link
Contributor

hcedwar commented Aug 31, 2016

Christian will get this into Kokkos develop branch nightly tests.

crtrott added a commit that referenced this issue Sep 21, 2016
This enables build and running of tutorial examples during with the main
build process. In particular it enables out-of-source builds for all
tutorial examples. It also fixes some warnings and issues when building
originally not planned for configurations.
crtrott added a commit that referenced this issue Sep 21, 2016
This adds discovery of nvcc compiler version, so that LAMBDA support
can be disabled in the Makefile. It will spit a warning if its requested.
A bugfix for issue #323
@crtrott crtrott closed this as completed Sep 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Create new capability; will potentially require voting
Projects
None yet
Development

No branches or pull requests

4 participants