-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tutorials to track new Kokkos::View #323
Comments
@ambrad Thanks for pointing that out, I checked with Carter and the tutorials need to be added to the testing. Marking this as feature request. @hcedwar @crtrott I'm guessing you fixed the issue, but for issue reference I built the tutorials on my laptop (clang compiler) and on kokkos-dev with cuda and did not have other build errors. |
Great, thanks! Yes, I switched the types and also seemed to have to write Kokkos::Impl::Timer instead of Kokkos::Timer. |
Another note, the most recent tutorial with learning materials (slides, codes) is available at [(https://github.com/kokkos/kokkos-tutorials)] |
@ambrad Was that in the same example (04_dualviews) where you had the issue with the timer? I wasn't able to replicate. |
I also had runtime errors when running the cuda build of that example that need fixing.
|
You are right about Timer; sorry for the false alarm. |
Add these to the nightly build |
Christian will get this into Kokkos develop branch nightly tests. |
This enables build and running of tutorial examples during with the main build process. In particular it enables out-of-source builds for all tutorial examples. It also fixes some warnings and issues when building originally not planned for configurations.
This adds discovery of nvcc compiler version, so that LAMBDA support can be disabled in the Makefile. It will spit a warning if its requested. A bugfix for issue #323
I think one or more of the tutorials need a few changes to track the new Kokkos::View. 04_dualviews uses array_intrinsic_type, for example.
The text was updated successfully, but these errors were encountered: