Check compiler version and print helpful message #39

kddevin · 2015-07-01T23:33:04Z

When we got compilation errors, Christian said it was due to our having an old compiler. Unfortunately, cmake didn't tell us that. Christian said, "I think Cmake doesn’t identify the compiler version internally. Though we could at least stop inside of Kokkos earlier. (I.e. Stop right away at the first compilation step with a compile time assert and a helpful message). Can you open an issue for that on the kokkos github page?"
Thanks.
Karen

This addresses Issue #39 github.com//issues/39

crtrott · 2015-07-15T14:19:15Z

This should work now at least for GCC, Intel and PGI. It will fail early with a helpful error message.

samaraseeri · 2015-08-10T09:03:21Z

Dear Folks,

I need the an older version of kokkos if you please. Have tried to build it on a cray machine with gnu but getting the following error "g++: error: unrecognized command line option '-h'". It was ablt to build the old version.

Thanks

jgfouca · 2015-08-10T15:57:08Z

Looking at this now.

crtrott · 2015-08-10T18:21:03Z

This has nothing to do with the version of Kokkos. This is complaining about an argument to the compiler i.e. part of the CXX Flags. Kokkos never adds a -h.

nmhamster · 2015-08-10T18:43:22Z

We just need to have the version checks also pipe error as well. Do you want me to add that, it "should be easy" (trademark).

samaraseeri · 2015-08-10T18:49:25Z

Hi,

I'm trying to build Kokkos on a Cray machine and getting the above error. A
month ago Kokkos was able to build with gcc without the above error. That
is why I'm asking for the older version if possible.

Best

On Mon, Aug 10, 2015 at 9:43 PM, Si Hammond notifications@github.com
wrote:

We just need to have the version checks also pipe error as well. Do you
want me to add that, it "should be easy" (trademark).

—
Reply to this email directly or view it on GitHub
#39 (comment).

Samar Aseeri, PhD
Computational Scientist
KAUST Supercomputing Laboratory (KSL) - Building 1 -Office: 0128
King Abdullah University of Science & Technology
Thuwal, Saudi Arabia

This message and its contents, including attachments are intended solely
for the original recipient. If you are not the intended recipient or have
received this message in error, please notify me immediately and delete
this message from your computer system. Any unauthorized use or
distribution is prohibited. Please consider the environment before printing
this email.

nmhamster · 2015-08-10T18:58:10Z

Should have a patch any second.

Si Hammond

Scalable Computer Architectures
Sandia National Laboratories, NM, USA

On 8/10/15, 12:49 PM, "samaraseeri" notifications@github.com wrote:

Hi,

I'm trying to build Kokkos on a Cray machine and getting the above error.
A
month ago Kokkos was able to build with gcc without the above error. That
is why I'm asking for the older version if possible.

Best

On Mon, Aug 10, 2015 at 9:43 PM, Si Hammond notifications@github.com
wrote:

We just need to have the version checks also pipe error as well. Do you
want me to add that, it "should be easy" (trademark).

—
Reply to this email directly or view it on GitHub
#39 (comment).

Samar Aseeri, PhD
Computational Scientist
KAUST Supercomputing Laboratory (KSL) - Building 1 -Office: 0128
King Abdullah University of Science & Technology
Thuwal, Saudi Arabia

This message and its contents, including attachments are intended solely
for the original recipient. If you are not the intended recipient or have
received this message in error, please notify me immediately and delete
this message from your computer system. Any unauthorized use or
distribution is prohibited. Please consider the environment before
printing
this email.
—
Reply to this email directly or
view it on GitHub
#39 (comment).

nmhamster · 2015-08-10T19:14:22Z

Can you try out the pull request diff in pull request #62 please? (#62). I think this should fix the error you are seeing.

samaraseeri · 2015-08-10T20:38:58Z

Cannot clone. It fails with the following message

git clone git@github.com:kokkos/kokkos.git
Cloning into 'kokkos'...
ssh: connect to host github.com port 22: Connection timed out
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

On Mon, Aug 10, 2015 at 10:14 PM, Si Hammond notifications@github.com
wrote:

Can you try out the pull request diff in pull request #62
#62 please? (#62
#62). I think this should fix the
error you are seeing.

—
Reply to this email directly or view it on GitHub
#39 (comment).

Samar Aseeri, PhD
Computational Scientist
KAUST Supercomputing Laboratory (KSL) - Building 1 -Office: 0128
King Abdullah University of Science & Technology
Thuwal, Saudi Arabia

This message and its contents, including attachments are intended solely
for the original recipient. If you are not the intended recipient or have
received this message in error, please notify me immediately and delete
this message from your computer system. Any unauthorized use or
distribution is prohibited. Please consider the environment before printing
this email.

crtrott · 2015-08-10T21:34:00Z

Si I don't understand how your patch would address the "-h" argument not recognized? That argument seems to come from the application which gets compiled not from Kokkos.

samaraseeri · 2015-08-10T22:07:37Z

Cannot clone latest change. Can anyone help.

Best

$ git clone git@github.com:kokkos/kokkos.git
Cloning into 'kokkos'...
The authenticity of host 'github.com (192.30.252.131)' can't be established.
RSA key fingerprint is 16:27:ac:a5:76:28:2d:36:63:1b:56:4d:eb:df:a6:48.
Are you sure you want to continue connecting (yes/no)? yes
Warning: Permanently added 'github.com,192.30.252.131' (RSA) to the list of
known hosts.
Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

On Tue, Aug 11, 2015 at 12:34 AM, Christian Trott notifications@github.com
wrote:

Si I don't understand how your patch would address the "-h" argument not
recognized? That argument seems to come from the application which gets
compiled not from Kokkos.

—
Reply to this email directly or view it on GitHub
#39 (comment).

Samar Aseeri, PhD
Computational Scientist
KAUST Supercomputing Laboratory (KSL) - Building 1 -Office: 0128
King Abdullah University of Science & Technology
Thuwal, Saudi Arabia

This message and its contents, including attachments are intended solely
for the original recipient. If you are not the intended recipient or have
received this message in error, please notify me immediately and delete
this message from your computer system. Any unauthorized use or
distribution is prohibited. Please consider the environment before printing
this email.

hcedwar · 2015-08-10T22:19:49Z

@samaraseeri
Apparently your github access (in general) is not configured properly. I presume that you cannot clone from any github.com repository. Go to the github.com main page and verify that you are setup correctly.

samaraseeri · 2015-08-10T22:38:01Z

Now getting:

git clone git@github.com:kokkos/kokkos.git
Cloning into 'kokkos'...
ssh: connect to host github.com port 22: Connection timed out
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

On Tue, Aug 11, 2015 at 1:19 AM, hcedwar notifications@github.com wrote:

@samaraseeri https://github.com/samaraseeri
Apparently your github access (in general) is not configured properly. I
presume that you cannot clone from any github.com repository. Go to the
github.com main page and verify that you are setup correctly.

—
Reply to this email directly or view it on GitHub
#39 (comment).

Samar Aseeri, PhD
Computational Scientist
KAUST Supercomputing Laboratory (KSL) - Building 1 -Office: 0128
King Abdullah University of Science & Technology
Thuwal, Saudi Arabia

This message and its contents, including attachments are intended solely
for the original recipient. If you are not the intended recipient or have
received this message in error, please notify me immediately and delete
this message from your computer system. Any unauthorized use or
distribution is prohibited. Please consider the environment before printing
this email.

nmhamster · 2015-08-10T23:00:52Z

The -h comes from the Makefile seeing GNU as Cray doesn't it?

Si Hammond
Scalable Computer Architectures
Sandia National Laboratories, NM
[Sent remotely, please excuse typing errors]

From: Christian Trott notifications@github.com
Sent: Monday, August 10, 2015 3:34:01 PM
To: kokkos/kokkos
Cc: Hammond, Simon David (-EXP)
Subject: [EXTERNAL] Re: [kokkos] Check compiler version and print helpful message (#39)

Si I don't understand how your patch would address the "-h" argument not recognized? That argument seems to come from the application which gets compiled not from Kokkos.

Reply to this email directly or view it on GitHubhttps://github.com//issues/39#issuecomment-129616301.

samaraseeri · 2015-08-10T23:04:01Z

When try to clone I get :

git clone git@github.com:kokkos/kokkos.git
Cloning into 'kokkos'...
ssh: connect to host github.com port 22: Connection timed out
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

On Tue, Aug 11, 2015 at 2:00 AM, Si Hammond notifications@github.com
wrote:

The -h comes from the Makefile seeing GNU as Cray doesn't it?

Si Hammond
Scalable Computer Architectures
Sandia National Laboratories, NM
[Sent remotely, please excuse typing errors]

From: Christian Trott notifications@github.com
Sent: Monday, August 10, 2015 3:34:01 PM
To: kokkos/kokkos
Cc: Hammond, Simon David (-EXP)
Subject: [EXTERNAL] Re: [kokkos] Check compiler version and print helpful
message (#39)

Si I don't understand how your patch would address the "-h" argument not
recognized? That argument seems to come from the application which gets
compiled not from Kokkos.

Reply to this email directly or view it on GitHub<
https://github.com/kokkos/kokkos/issues/39#issuecomment-129616301>.

—
Reply to this email directly or view it on GitHub
#39 (comment).

Samar Aseeri, PhD
Computational Scientist
KAUST Supercomputing Laboratory (KSL) - Building 1 -Office: 0128
King Abdullah University of Science & Technology
Thuwal, Saudi Arabia

This message and its contents, including attachments are intended solely
for the original recipient. If you are not the intended recipient or have
received this message in error, please notify me immediately and delete
this message from your computer system. Any unauthorized use or
distribution is prohibited. Please consider the environment before printing
this email.

samaraseeri · 2015-08-10T23:04:31Z

When try to clone I get :

git clone git@github.com:kokkos/kokkos.git
Cloning into 'kokkos'...
ssh: connect to host github.com port 22: Connection timed out
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

Best

On Tue, Aug 11, 2015 at 2:04 AM, Samar Aseeri samar.aseeri@kaust.edu.sa
wrote:

When try to clone I get :

git clone git@github.com:kokkos/kokkos.git
Cloning into 'kokkos'...
ssh: connect to host github.com port 22: Connection timed out
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

On Tue, Aug 11, 2015 at 2:00 AM, Si Hammond notifications@github.com
wrote:

The -h comes from the Makefile seeing GNU as Cray doesn't it?

Si Hammond
Scalable Computer Architectures
Sandia National Laboratories, NM
[Sent remotely, please excuse typing errors]

From: Christian Trott notifications@github.com
Sent: Monday, August 10, 2015 3:34:01 PM
To: kokkos/kokkos
Cc: Hammond, Simon David (-EXP)
Subject: [EXTERNAL] Re: [kokkos] Check compiler version and print helpful
message (#39)

Si I don't understand how your patch would address the "-h" argument not
recognized? That argument seems to come from the application which gets
compiled not from Kokkos.

Reply to this email directly or view it on GitHub<
https://github.com/kokkos/kokkos/issues/39#issuecomment-129616301>.

—
Reply to this email directly or view it on GitHub
#39 (comment).

Samar Aseeri, PhD
Computational Scientist
KAUST Supercomputing Laboratory (KSL) - Building 1 -Office: 0128
King Abdullah University of Science & Technology
Thuwal, Saudi Arabia

Samar Aseeri, PhD
Computational Scientist
KAUST Supercomputing Laboratory (KSL) - Building 1 -Office: 0128
King Abdullah University of Science & Technology
Thuwal, Saudi Arabia

This message and its contents, including attachments are intended solely
for the original recipient. If you are not the intended recipient or have
received this message in error, please notify me immediately and delete
this message from your computer system. Any unauthorized use or
distribution is prohibited. Please consider the environment before printing
this email.

crtrott · 2015-08-10T23:04:42Z

Ah the -hstd=c++11 I overlooked that. Yes thats right. Samaraseeri: try cloning via the https route:
git clone https://github.com/kokkos/kokkos.git

samaraseeri · 2015-08-10T23:08:16Z

Yes, the build completed. Thanks for the help.

Best

On Tue, Aug 11, 2015 at 2:04 AM, Christian Trott notifications@github.com
wrote:

Ah the -hstd=c++11 I overlooked that. Yes thats right. Samaraseeri: try
cloning via the https route:
git clone https://github.com/kokkos/kokkos.git

—
Reply to this email directly or view it on GitHub
#39 (comment).

Samar Aseeri, PhD
Computational Scientist
KAUST Supercomputing Laboratory (KSL) - Building 1 -Office: 0128
King Abdullah University of Science & Technology
Thuwal, Saudi Arabia

This message and its contents, including attachments are intended solely
for the original recipient. If you are not the intended recipient or have
received this message in error, please notify me immediately and delete
this message from your computer system. Any unauthorized use or
distribution is prohibited. Please consider the environment before printing
this email.

nmhamster · 2015-08-10T23:25:15Z

I have/(had) a test case which caught the -hstd=c++11 here so regardless it is an issue :(.

nmhamster · 2015-08-10T23:25:53Z

@crtrott @hcedwar Can you merge pull request #62 into the develop when you have time please?

crtrott · 2015-09-05T00:55:26Z

I think this is addressed please reopen if not.

crtrott added a commit that referenced this issue Jul 9, 2015

Compilers: Adding check for minimal version of GCC, Intel and PGI

7328665

This addresses Issue #39 github.com//issues/39

crtrott closed this as completed Jul 15, 2015

hcedwar reopened this Aug 10, 2015

hcedwar assigned jgfouca Aug 10, 2015

crtrott closed this as completed Sep 5, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Check compiler version and print helpful message #39

Check compiler version and print helpful message #39

kddevin commented Jul 1, 2015

crtrott commented Jul 15, 2015

samaraseeri commented Aug 10, 2015

jgfouca commented Aug 10, 2015

crtrott commented Aug 10, 2015

nmhamster commented Aug 10, 2015

samaraseeri commented Aug 10, 2015

nmhamster commented Aug 10, 2015

nmhamster commented Aug 10, 2015

samaraseeri commented Aug 10, 2015

crtrott commented Aug 10, 2015

samaraseeri commented Aug 10, 2015

hcedwar commented Aug 10, 2015

samaraseeri commented Aug 10, 2015

nmhamster commented Aug 10, 2015

samaraseeri commented Aug 10, 2015

samaraseeri commented Aug 10, 2015

crtrott commented Aug 10, 2015

samaraseeri commented Aug 10, 2015

nmhamster commented Aug 10, 2015

nmhamster commented Aug 10, 2015

crtrott commented Sep 5, 2015

Check compiler version and print helpful message #39

Check compiler version and print helpful message #39

Comments

kddevin commented Jul 1, 2015

crtrott commented Jul 15, 2015

samaraseeri commented Aug 10, 2015

jgfouca commented Aug 10, 2015

crtrott commented Aug 10, 2015

nmhamster commented Aug 10, 2015

samaraseeri commented Aug 10, 2015

nmhamster commented Aug 10, 2015

nmhamster commented Aug 10, 2015

samaraseeri commented Aug 10, 2015

crtrott commented Aug 10, 2015

samaraseeri commented Aug 10, 2015

hcedwar commented Aug 10, 2015

samaraseeri commented Aug 10, 2015

nmhamster commented Aug 10, 2015

samaraseeri commented Aug 10, 2015

samaraseeri commented Aug 10, 2015

crtrott commented Aug 10, 2015

samaraseeri commented Aug 10, 2015

nmhamster commented Aug 10, 2015

nmhamster commented Aug 10, 2015

crtrott commented Sep 5, 2015