Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add correctness testing for all operators of Atomic View #420

Closed
crtrott opened this issue Sep 5, 2016 · 1 comment
Closed

Add correctness testing for all operators of Atomic View #420

crtrott opened this issue Sep 5, 2016 · 1 comment
Assignees
@ndellingwood
Labels
Enhancement Improve existing capability; will potentially require voting
Milestone
2017-January

Comments

@crtrott
Copy link
Member

crtrott commented Sep 5, 2016

Looks like we don't actually check all operations possible on the atomic view meta object. That needs to get fixed.
@crtrott crtrott added the Enhancement Improve existing capability; will potentially require voting label Sep 5, 2016
@crtrott crtrott added this to the Fall 2016 milestone Sep 5, 2016
@ndellingwood
Copy link
Contributor

Which got missed? Sorry about that

@hcedwar hcedwar modified the milestones: END 2016, Fall 2016 Nov 1, 2016
ndellingwood added a commit to ndellingwood/kokkos that referenced this issue Dec 15, 2016
@ndellingwood
AtomicViewTests: Add unit tests for atomic views
9b74199 
This commit address Kokkos Github issue kokkos#420
New unit tests added to test Views with the Kokkos::Atomic memory trait

 Changes to be committed:
	new file:   core/unit_test/TestAtomicViews.hpp
	modified:   core/unit_test/cuda/TestCuda.hpp
	modified:   core/unit_test/cuda/TestCuda_Atomics.cpp
	modified:   core/unit_test/openmp/TestOpenMP.hpp
	modified:   core/unit_test/openmp/TestOpenMP_Atomics.cpp
	modified:   core/unit_test/serial/TestSerial.hpp
	modified:   core/unit_test/serial/TestSerial_Atomics.cpp
	modified:   core/unit_test/threads/TestThreads.hpp
	modified:   core/unit_test/threads/TestThreads_Atomics.cpp
@ndellingwood ndellingwood mentioned this issue Dec 15, 2016
Merged
ndellingwood added a commit to ndellingwood/kokkos that referenced this issue Dec 16, 2016
@ndellingwood
AtomicViewTests: Add unit tests for atomic views
77e7980 
This commit address Kokkos Github issue kokkos#420
New unit tests added to test Views with the Kokkos::Atomic memory trait

 Changes to be committed:
	new file:   core/unit_test/TestAtomicViews.hpp
	modified:   core/unit_test/cuda/TestCuda.hpp
	modified:   core/unit_test/cuda/TestCuda_Atomics.cpp
	modified:   core/unit_test/openmp/TestOpenMP.hpp
	modified:   core/unit_test/openmp/TestOpenMP_Atomics.cpp
	modified:   core/unit_test/serial/TestSerial.hpp
	modified:   core/unit_test/serial/TestSerial_Atomics.cpp
	modified:   core/unit_test/threads/TestThreads.hpp
	modified:   core/unit_test/threads/TestThreads_Atomics.cpp
@hcedwar hcedwar modified the milestones: 2016-January, END 2016 Jan 3, 2017
@crtrott crtrott closed this as completed Feb 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ndellingwood ndellingwood

Labels
Enhancement Improve existing capability; will potentially require voting
Projects
None yet
Milestone
2017-January
Development

No branches or pull requests
4 participants
@hcedwar @dsunder @crtrott @ndellingwood