Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenMP TeamPolicy member broadcast not using correct volatile shared variable #424

Closed
hcedwar opened this issue Sep 8, 2016 · 3 comments
Closed

OpenMP TeamPolicy member broadcast not using correct volatile shared variable #424

hcedwar opened this issue Sep 8, 2016 · 3 comments
Assignees
@hcedwar
Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Milestone
Fall 2016

Comments

@hcedwar
Copy link
Contributor

hcedwar commented Sep 8, 2016

https://github.com/kokkos/kokkos/blob/master/core/src/OpenMP/Kokkos_OpenMPexec.hpp#L396
should have volatile
@hcedwar hcedwar added the Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) label Sep 30, 2016
@hcedwar hcedwar added this to the Fall 2016 milestone Sep 30, 2016
@hcedwar hcedwar self-assigned this Sep 30, 2016
@hcedwar
Copy link
Contributor Author

hcedwar commented Sep 30, 2016 •
edited

OpenMP thread team broadcast is not using a shared variable - fix and add necessary memory fence and barriers.

@hcedwar hcedwar changed the title OpenMP TeamPolicy member barrier missing volatile OpenMP TeamPolicy member barrier not using correct volatile shared variable Sep 30, 2016
hcedwar added a commit that referenced this issue Sep 30, 2016
@hcedwar
Bug fix issue #424
91cfb3d
@hcedwar
Copy link
Contributor Author

hcedwar commented Oct 5, 2016

Need to have unit test

@crtrott crtrott changed the title OpenMP TeamPolicy member barrier not using correct volatile shared variable OpenMP TeamPolicy member broadcast not using correct volatile shared variable Oct 19, 2016
@crtrott
Copy link
Member

crtrott commented Oct 19, 2016

Fixed name of issue :-)

@crtrott crtrott closed this as completed Oct 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hcedwar hcedwar

Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Projects
None yet
Milestone
Fall 2016
Development

No branches or pull requests
2 participants
@hcedwar @crtrott