Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Profiling by default in Tribits build #438

Closed
crtrott opened this issue Sep 21, 2016 · 4 comments
Closed

Enable Profiling by default in Tribits build #438

crtrott opened this issue Sep 21, 2016 · 4 comments
Assignees
Labels
Enhancement Improve existing capability; will potentially require voting

Comments

@crtrott
Copy link
Member

crtrott commented Sep 21, 2016

This is documenting that we want to enable Profiling by enabling the DLlib by default in a Trillions build. We already enable it by default in Makefile builds. This is done by marking DLlib as an tentatively enabled library.

@crtrott crtrott added the Enhancement Improve existing capability; will potentially require voting label Sep 21, 2016
@crtrott crtrott self-assigned this Sep 21, 2016
crtrott added a commit that referenced this issue Sep 21, 2016
This will make Profiling hooks available by default.
Addresses issue #438
@mhoemmen
Copy link
Contributor

@crtrott Does profiling only work with dynamic shared libraries? It's OK if not; we can just disable the profiling option in that case, with a suitable warning message.

Note that some customers insist upon static library builds of Trilinos. I'm not pleased that they do; static libraries increase build times, and prevent me from having a function called if a package is linked in (see e.g., LinearSolverFactory's desired dependency injection).

@nmhamster
Copy link
Contributor

@mhoemmen works for both build types.

@crtrott
Copy link
Member Author

crtrott commented Sep 21, 2016

Yeah this works with static and dynamic links. The profiling tools themselves are linked in via explicit dynamic loads at runtime. The DLlib can be statically linked into the executable though.

@mhoemmen
Copy link
Contributor

@crtrott @nmhamster good good, thanks :)

@crtrott crtrott closed this as completed Sep 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improve existing capability; will potentially require voting
Projects
None yet
Development

No branches or pull requests

3 participants