Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing Reducer Test on Mac with Pthreads #479

Closed
crtrott opened this issue Oct 15, 2016 · 2 comments
Closed

Failing Reducer Test on Mac with Pthreads #479

crtrott opened this issue Oct 15, 2016 · 2 comments
Assignees
@crtrott
Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Milestone
Fall 2016

Comments

@crtrott
Copy link
Member

crtrott commented Oct 15, 2016 

[ RUN      ] threads.reducers
/Users/crtrott/Kokkos/kokkos/core/unit_test/TestReduce.hpp:1581: Failure
Value of: reference_minloc
  Actual: 3611
Expected: minmax_scalar.min_loc
Which is: 8639
[  FAILED  ] threads.reducers (5 ms)
@crtrott crtrott added the Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) label Oct 15, 2016
@crtrott
Copy link
Member Author

crtrott commented Oct 15, 2016

Might be just the test being broken (i.e. if the random numbers have multiple equal minima location the serial control loop doesn't come back with the same location as the parallel reduction).

@crtrott
Copy link
Member Author

crtrott commented Oct 16, 2016

OK confirmed. I guess on the other platforms the min and max values were unique, but on my mac they weren't. Gonna push a fix later.

@crtrott crtrott added this to the Fall 2016 milestone Oct 16, 2016
@crtrott crtrott self-assigned this Oct 16, 2016
crtrott added a commit that referenced this issue Oct 18, 2016
@crtrott
Fixing Bug in Test: fix issue #479
ca73469
@crtrott crtrott closed this as completed Oct 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crtrott crtrott

Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Projects
None yet
Milestone
Fall 2016
Development

No branches or pull requests
1 participant
@crtrott