Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate sort(View, bool always_call_kokkos_sort) #5382

Closed
PhilMiller opened this issue Aug 24, 2022 · 1 comment · Fixed by #5384
Closed

Deprecate sort(View, bool always_call_kokkos_sort) #5382

PhilMiller opened this issue Aug 24, 2022 · 1 comment · Fixed by #5384
Assignees
@PhilMiller
Labels
Blocks Promotion Overview issue for release-blocking bugs Deprecate Items to be deprecated InDevelop Enhancement, fix, etc. has been merged into the develop branch;
Projects
Developer: Phil Miller
Milestone
Tentative 3.7 Rel...

Comments

@PhilMiller
Copy link
Contributor

Steer users to a new overload that doesn't take the trailing bool argument
@PhilMiller PhilMiller added Blocks Promotion Overview issue for release-blocking bugs Deprecate Items to be deprecated labels Aug 24, 2022
@PhilMiller PhilMiller added this to the Tentative 3.7 Release milestone Aug 24, 2022
@PhilMiller PhilMiller self-assigned this Aug 24, 2022
@PhilMiller PhilMiller added this to In progress in Developer: Phil Miller Aug 24, 2022
PhilMiller added a commit that referenced this issue Aug 24, 2022
@PhilMiller
#5382: Deprecate overloads of Kokkos::sort() taking parameter 'bool a…
2f2155b 
…lways_use_kokkos_sort'
@PhilMiller PhilMiller linked a pull request Aug 24, 2022 that will close this issue
[3.7] #5382: Deprecate overloads of Kokkos::sort() taking parameter 'bool always_use_kokkos_sort' #5384
Merged
PhilMiller added a commit that referenced this issue Aug 24, 2022
@PhilMiller
#5382: Deprecate overloads of Kokkos::sort() taking parameter 'bool a…
54e988b 
…lways_use_kokkos_sort'
PhilMiller added a commit that referenced this issue Aug 24, 2022
@PhilMiller
#5382: Deprecate overloads of Kokkos::sort() taking parameter 'bool a…
0971348 
…lways_use_kokkos_sort'
crtrott added a commit that referenced this issue Aug 25, 2022
@crtrott
Merge pull request #5384 from kokkos/5382-3.7-deprecate-sort-bool
86cbc84 
[3.7] #5382: Deprecate overloads of Kokkos::sort() taking parameter 'bool always_use_kokkos_sort'
crtrott added a commit that referenced this issue Aug 29, 2022
@crtrott
Merge pull request #5388 from kokkos/5382-develop-deprecate-sort-bool
2daa5e4 
#5382: Delete deprecated overloads of Kokkos::sort() taking parameter 'bool always_use_kokkos_sort'
@PhilMiller PhilMiller moved this from In progress to Done, pending release in Developer: Phil Miller Aug 30, 2022
@PhilMiller PhilMiller added the InDevelop Enhancement, fix, etc. has been merged into the develop branch; label Aug 30, 2022
JBludau pushed a commit to JBludau/kokkos that referenced this issue Sep 1, 2022
@PhilMiller @JBludau
kokkos#5382: Deprecate overloads of Kokkos::sort() taking parameter '…
644b967 
…bool always_use_kokkos_sort'
cz4rs pushed a commit to cz4rs/kokkos that referenced this issue Sep 15, 2022
@PhilMiller @cz4rs
kokkos#5382: Deprecate overloads of Kokkos::sort() taking parameter '…
b794584 
…bool always_use_kokkos_sort'
@PhilMiller
Copy link
Contributor Author

Fix released in 3.7.00

Developer: Phil Miller automation moved this from Done in Release 3.7 to Pending release 4.0 Oct 6, 2022
@ajpowelsnl ajpowelsnl mentioned this issue Nov 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PhilMiller PhilMiller

Labels
Blocks Promotion Overview issue for release-blocking bugs Deprecate Items to be deprecated InDevelop Enhancement, fix, etc. has been merged into the develop branch;
Projects
Developer: Phil Miller
Done in release 4.0
Milestone
Tentative 3.7 Release
1 participant
@PhilMiller