Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nvcc_wrapper not installed with Kokkos built with CUDA through CMake #543

Closed
mfdeakin-sandia opened this issue Nov 15, 2016 · 7 comments
Closed
Assignees
Labels
Enhancement Improve existing capability; will potentially require voting
Milestone

Comments

@mfdeakin-sandia
Copy link

Building and installing Kokkos through the Trilinos CMake configure script does not install nvcc_wrapper. This prevents building programs which depend on Kokkos when Kokkos has been built and installed with CUDA support.

@crtrott
Copy link
Member

crtrott commented Nov 15, 2016

You are right that is an oversight. I'll fix it.

@crtrott crtrott added the Enhancement Improve existing capability; will potentially require voting label Nov 15, 2016
@crtrott crtrott added this to the END 2016 milestone Nov 15, 2016
@crtrott
Copy link
Member

crtrott commented Nov 15, 2016

@mhoemmen Mark if you see this, and you feel like you can fix it in 5 mins please feel free to do so. If not I try to figure out how to add this to our CMake files. If you do it, install the copy from the kokkos/bin directory. I want to delete it inside of config at some point.

@mhoemmen
Copy link
Contributor

@crtrott wrote:

Mark if you see this, and you feel like you can fix it in 5 mins please feel free to do so. If not I try to figure out how to add this to our CMake files. If you do it, install the copy from the kokkos/bin directory. I want to delete it inside of config at some point.

Sure, let me take a look now.

@mhoemmen
Copy link
Contributor

@crtrott Where should CMake install the file? Should the install directory have a kokkos/bin subdirectory?

@crtrott
Copy link
Member

crtrott commented Dec 1, 2016

Just into INSTALL/bin is fine.

@mhoemmen
Copy link
Contributor

mhoemmen commented Dec 5, 2016

I'm working on this now. I wanted to check CMake 2.8.x vs. CMake 3 documentation to make sure that we could use the same command for both. We can :-) Here is the command:

INSTALL(PROGRAMS ${SCRIPT_PATH_IN_SOURCE} DESTINATION bin)

The DESTINATION path, if relative, is relative to ${CMAKE_INSTALL_PATH}. That is exactly what we want in this case. The PROGRAMS keyword tells CMake to mark the installed script as executable.

@mhoemmen
Copy link
Contributor

mhoemmen commented Dec 6, 2016

Just pushed fix to develop branch.

@crtrott crtrott closed this as completed Dec 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improve existing capability; will potentially require voting
Projects
None yet
Development

No branches or pull requests

3 participants