Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XL 13.1.4 incorrect C++11 flag #553

Closed
tomdeakin opened this issue Nov 30, 2016 · 4 comments
Closed

XL 13.1.4 incorrect C++11 flag #553

tomdeakin opened this issue Nov 30, 2016 · 4 comments
Assignees
Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Milestone

Comments

@tomdeakin
Copy link

If I setup Kokkos with the IBM XL 13.1.4 compiler as follows,
CXX=xlc++ ../../generate_makefile.bash --prefix=$PWD/.. --with-openmp --arch=Power8
it sets --std=c++11 in Makefile.kokkos.

This causes any user code to fail to build with warning: 1501-257 Option std=c++11 is not recognized. Option will be ignored.

The xlc++ --help page says the flag should be -std=c++11.

This is using Kokkos at the 2.02.01 tag.

@nmhamster
Copy link
Contributor

I think you should do --compiler=xlc++ on the generate_makefike.sh

@tomdeakin
Copy link
Author

Thanks, that now works OK. If I have CXX=xlc++ set in my environment though, shouldn't the build work out I'm using xlc++ for me?

@nmhamster
Copy link
Contributor

Why would we do that ;-)! It's a bug. Thanks for reporting it.

@crtrott
Copy link
Member

crtrott commented Nov 30, 2016

Ok found the issue. The -qversion option spits out a different format, so our makefile doesn't identify the compiler correctly.

@crtrott crtrott added the Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) label Nov 30, 2016
@crtrott crtrott added this to the END 2016 milestone Nov 30, 2016
@crtrott crtrott self-assigned this Dec 1, 2016
crtrott added a commit that referenced this issue Dec 1, 2016
We might want to think about a more robust way of figuring out the
compiler: for example larger than comparisons.
@crtrott crtrott closed this as completed Dec 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Projects
None yet
Development

No branches or pull requests

3 participants