Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in generate_makefile.sh for Kokkos when Compiler is Empty String/Fails #568

Closed
nmhamster opened this issue Dec 8, 2016 · 2 comments
Closed

Error in generate_makefile.sh for Kokkos when Compiler is Empty String/Fails #568

nmhamster opened this issue Dec 8, 2016 · 2 comments
Assignees
@crtrott
Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Milestone
END 2016

Comments

@nmhamster
Copy link
Contributor

generate_makefile.sh --compiler=which pgc++ will switch back to using g++ if the pgc++ is not in the $PATH.

This implies that an empty string does not force an error if --compiler option is specified. This should print an error and stop further execution. It could easily lead to a scenario where we inadvertently are not running the correct compiler.
@nmhamster nmhamster added the Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) label Dec 8, 2016
@crtrott crtrott self-assigned this Dec 14, 2016
@crtrott
Copy link
Member

crtrott commented Dec 14, 2016

I'll do it.

@crtrott crtrott added this to the END 2016 milestone Dec 14, 2016
crtrott added a commit that referenced this issue Dec 15, 2016
@crtrott
Address issue #568
8265cc4
@crtrott
Copy link
Member

crtrott commented Dec 15, 2016

Fixed.

@crtrott crtrott closed this as completed Dec 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crtrott crtrott

Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Projects
None yet
Milestone
END 2016
Development

No branches or pull requests
2 participants
@nmhamster @crtrott