Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

atomic test hangs with LLVM #6

Closed
crtrott opened this issue Apr 24, 2015 · 1 comment
Closed

atomic test hangs with LLVM #6

crtrott opened this issue Apr 24, 2015 · 1 comment
Assignees
@crtrott
Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)

Comments

@crtrott
Copy link
Member

crtrott commented Apr 24, 2015

The atomic test seems to hang with LLVM both on Linux and Mac. Something must be going bad there.
@crtrott crtrott added the Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) label Apr 24, 2015
@crtrott
Copy link
Member Author

crtrott commented Apr 26, 2015

Found the issue. With LLVM KOKKOS_ENABLE_ASM is not defined: i.e. x86 assembly is not enabled.
This means atomic_exchange on Kokkos::complex does only work correctly in serial.
This function is even without KOKKOS_ENABLE_ASM defined in order to support serial builds on Mac Books for Trilinos. Unfortunately the test for that atomic was not properly guarded. Thus the a manual CAS loop to test atomic_exchange would loop indefinitely when using threads.
A fix is pushed.

@crtrott crtrott closed this as completed Apr 26, 2015
@bathmatt bathmatt mentioned this issue Oct 1, 2015
Closed
@crtrott crtrott self-assigned this Sep 20, 2016
Rombur added a commit to Rombur/kokkos that referenced this issue May 21, 2019
@Rombur
Merge pull request kokkos#6 from crtrott/hip-work
4d1f348 
Hip work
e10harvey pushed a commit to e10harvey/kokkos that referenced this issue Oct 13, 2020
@crtrott
Merge pull request kokkos#6 from e10harvey/add-half-precision-base-su…
850b232 
…pport

Add Cuda half_t type and operators
@ndellingwood ndellingwood mentioned this issue Nov 4, 2020
Merged
dalg24 pushed a commit to dalg24/kokkos that referenced this issue Dec 1, 2020
@ibaned
Merge pull request kokkos#6 from tasmith4/volatile
be25089 
add volatile overloads for simd double constructor and plus equals
@mewall mewall mentioned this issue Mar 31, 2022
Closed
dalg24 pushed a commit to dalg24/kokkos that referenced this issue May 2, 2022
@crtrott
Merge pull request kokkos#6 from NexGenAnalytics/std_algorithms
1dd9775 
[ready] stdalgorithms
@scottbiersdorff scottbiersdorff mentioned this issue Oct 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crtrott crtrott

Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@crtrott