Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenMP: error out if KOKKOS_HAVE_OPENMP is defined but not _OPENMP #605

Closed
crtrott opened this issue Jan 10, 2017 · 0 comments
Closed

OpenMP: error out if KOKKOS_HAVE_OPENMP is defined but not _OPENMP #605

crtrott opened this issue Jan 10, 2017 · 0 comments
Assignees
@crtrott
Labels
Enhancement Improve existing capability; will potentially require voting
Milestone
2017-January

Comments

@crtrott
Copy link
Member

crtrott commented Jan 10, 2017

This can happen in CMake configuration. In our GNU builds we control this stuff usually.
@crtrott crtrott added the Enhancement Improve existing capability; will potentially require voting label Jan 10, 2017
@crtrott crtrott added this to the 2017-February milestone Jan 10, 2017
@crtrott crtrott self-assigned this Jan 10, 2017
crtrott added a commit that referenced this issue Jan 10, 2017
@crtrott
OpenMP: throw compile time error if _OPENMP is not defined
376800c 
With CMake it was pretty simple to tell Kokkos to enable OpenMP,
without telling the compiler to do OpenMP. This led to weird
incomplete definition errors. This adds a nice compile time
error message about the problem.

Addresses #605
@crtrott crtrott modified the milestones: 2016-January, 2017-February Jan 12, 2017
@crtrott crtrott closed this as completed Feb 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crtrott crtrott

Labels
Enhancement Improve existing capability; will potentially require voting
Projects
None yet
Milestone
2017-January
Development

No branches or pull requests
1 participant
@crtrott