Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

View bounds checking on host-side performance: constructing a std::string #723

Closed
hcedwar opened this issue Apr 10, 2017 · 0 comments
Closed

View bounds checking on host-side performance: constructing a std::string #723

hcedwar opened this issue Apr 10, 2017 · 0 comments
Labels
Enhancement Improve existing capability; will potentially require voting
Milestone
2017-July-end

Comments

@hcedwar
Copy link
Contributor

hcedwar commented Apr 10, 2017

The View bounds checking constructs (allocates) and destructs (deallocates) a std::string at every multidimensional array member access. This causes a serious performance degradation and needs to be reimplemented/redesigned to avoid std::string thrashing.
@hcedwar hcedwar added the Enhancement Improve existing capability; will potentially require voting label Apr 10, 2017
@hcedwar hcedwar added this to the Backlog milestone Apr 10, 2017
@hcedwar hcedwar mentioned this issue Apr 27, 2017
Closed
hcedwar added a commit that referenced this issue Apr 28, 2017
@hcedwar
Debug bounds checking defers querying the View string label
c42cfec 
until a bounds violation actually occurs: #723 and #741
@hcedwar hcedwar modified the milestones: 2017-June-end, Backlog Apr 28, 2017
@crtrott crtrott closed this as completed May 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement Improve existing capability; will potentially require voting
Projects
None yet
Milestone
2017-July-end
Development

No branches or pull requests
2 participants
@hcedwar @crtrott