Output from PerTeam fails

[bathmatt]

Here is a simple example that I sent to @crtrott but wanted tracking in github. This works fine with PerThread

BTW, This is with a pull from this a.m. into a standard trilinos build.

      int shared_index;
      Kokkos::single(Kokkos::PerTeam(team_member),[&] (int& idx) {
         idx = Kokkos::atomic_fetch_add(&iter(0),1);
      },shared_index);

This gives the error

                 from /home/mbetten/installs/install-for-panzer/gcc-DEBUG/include/Kokkos_Core.hpp:53,
                 from /home/mbetten/Trilinos/N-Body/src/const_len_vector.hpp:10,
                 from /home/mbetten/Trilinos/N-Body/src/main.cpp:1:
/home/mbetten/installs/install-for-panzer/gcc-DEBUG/include/impl/Kokkos_HostThreadTeam.hpp: In instantiation of ‘void Kokkos::single(const Kokkos::Impl::ThreadSingleStruct<Kokkos::Impl::HostThreadTeamMember<Space> >&, const FunctorType&, ValueType&) [with Space = Kokkos::OpenMP; FunctorType = MatrixBuilder::operator()(const MemberType&) const::<lambda(int&)>; ValueType = int]’:
/home/mbetten/Trilinos/N-Body/src/Matrix.hpp:301:21:   required from here
/home/mbetten/installs/install-for-panzer/gcc-DEBUG/include/impl/Kokkos_HostThreadTeam.hpp:1067:3: error: call of overloaded ‘team_broadcast(const MatrixBuilder::operator()(const MemberType&) const::<lambda(int&)>&, int&)’ is ambiguous
   single.team_member.team_broadcast( functor , val );
   ^~~~~~
In file included from /home/mbetten/installs/install-for-panzer/gcc-DEBUG/include/Kokkos_Serial.hpp:59:0,
                 from /home/mbetten/installs/install-for-panzer/gcc-DEBUG/include/Kokkos_Core.hpp:53,
                 from /home/mbetten/Trilinos/N-Body/src/const_len_vector.hpp:10,
                 from /home/mbetten/Trilinos/N-Body/src/main.cpp:1:
/home/mbetten/installs/install-for-panzer/gcc-DEBUG/include/impl/Kokkos_HostThreadTeam.hpp:542:8: note: candidate: void Kokkos::Impl::HostThreadTeamMember<HostExecSpace>::team_broadcast(T&, int) const [with T = const MatrixBuilder::operator()(const MemberType&) const::<lambda(int&)>; HostExecSpace = Kokkos::OpenMP]
   void team_broadcast( T & value , const int source_team_rank = 0 ) const noexcept
        ^~~~~~~~~~~~~~
/home/mbetten/installs/install-for-panzer/gcc-DEBUG/include/impl/Kokkos_HostThreadTeam.hpp:574:8: note: candidate: void Kokkos::Impl::HostThreadTeamMember<HostExecSpace>::team_broadcast(const Closure&, T&) const [with Closure = MatrixBuilder::operator()(const MemberType&) const::<lambda(int&)>; T = int; HostExecSpace = Kokkos::OpenMP]
   void team_broadcast( Closure const & f , T & value ) const noexcept

[crtrott]

Confirmed failure. Works on master fails on develop:

#include<Kokkos_Core.hpp>

int main(int argc, char* argv[]) {
  Kokkos::initialize(argc,argv);

  Kokkos::View<int*> iter("Iter",1);

  Kokkos::parallel_for(Kokkos::TeamPolicy<>(1,1), KOKKOS_LAMBDA (const Kokkos::TeamPolicy<>::member_type& team) {
    int shared_index;
      Kokkos::single(Kokkos::PerTeam(team),[&] (int& idx) {
         idx = Kokkos::atomic_fetch_add(&iter(0),1);
      },shared_index);
  });
  Kokkos::finalize();
}

[crtrott]

The problem was the addition of a team_broadcast function which takes a functor and a value but not a root index. Making a root index mandatory fixes this.

[bathmatt]

Can I get this in english please, or in code? or is it in kokkos where the issue lies? or is it fixed? I have to use develop since there are other bugs in master I need to work around.

…

On Mon, Apr 17, 2017 at 3:47 PM, Christian Trott ***@***.***> wrote: The problem was the addition of a team_broadcast function which takes a functor and a value but not a root index. Making a root index mandatory fixes this. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#733 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AOPDIL_zpddW3VvB988V0NseokUqbIzeks5rw93ggaJpZM4M88Sm> .