Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw with Cuda when using (2D) team_policy parallel_reduce with less than a warp size #76

Closed
crtrott opened this issue Aug 26, 2015 · 2 comments
Closed

Throw with Cuda when using (2D) team_policy parallel_reduce with less than a warp size #76

crtrott opened this issue Aug 26, 2015 · 2 comments
Assignees
@crtrott
Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)

Comments

@crtrott
Copy link
Member

crtrott commented Aug 26, 2015

It already throws when not a power of two. But it needs to throw for 2,4,8,16 as well.
@crtrott crtrott added the Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) label Aug 26, 2015
crtrott added a commit that referenced this issue Sep 4, 2015
@crtrott
Cuda: THrow with parallel_reduce and team_size < 32
6a5c22d 
This closes issue #76
@crtrott crtrott closed this as completed Sep 4, 2015
@crtrott
Copy link
Member Author

crtrott commented Sep 4, 2015

I should not close before it is in master.

@crtrott crtrott reopened this Sep 4, 2015
@crtrott crtrott added bug - fix pushed for public testing Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) and removed Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) labels Sep 4, 2015
@crtrott
Copy link
Member Author

crtrott commented Sep 16, 2015

Pushed to master

@crtrott crtrott closed this as completed Sep 16, 2015
@crtrott crtrott self-assigned this Sep 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crtrott crtrott

Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@crtrott