-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Append tag name to parallel construct name for Profiling #842
Comments
Not sure how feasible this is yet, but conceptually it makes sense |
Its something we could do. Need to check how much launch latency it adds. But basically we use already typeid(functor).name() as default label, and we can simply append it with typeid(policy_type::tag_type).name() or so. |
If the launch latency is high, then could you only enable it when profiling is also enabled? |
@stanmoore1 I think thats already the case for the existing code that queries the |
The issue here is that we want to have profiling be enabled by default. We may end up with some functions for profiling disabled if they affect performance but the premise is "always available profiling". We can talk offline as to why this is important. |
I created PR #846, which I think will do what you want. I guess we could do some kind of performance testing with LAMMPS to see how it affects latency ? |
I think it should be ok. That said, all pull requests are on hold until: |
Incorporate tags into profiling names [#842]
The changes are in develop |
@ibaned thanks! |
Just wanted to say thanks again for this enhancement, it makes profiling my code a lot easier |
carry-over kokkos/kokkos-tools#14
@stanmoore1
The text was updated successfully, but these errors were encountered: