Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parallel_Reduce with TeamPolicy and league size of 0 returns garbage #85

Closed
crtrott opened this issue Sep 10, 2015 · 1 comment
Closed

Parallel_Reduce with TeamPolicy and league size of 0 returns garbage #85

crtrott opened this issue Sep 10, 2015 · 1 comment
Assignees
@crtrott
Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)

Comments

@crtrott
Copy link
Member

crtrott commented Sep 10, 2015

Reported by Matt Bettencourt: apparently the reduction with a team_policy with league size 0 returns garbage. Probably because it still copies the values from the internal buffers to the result buffer, but the internal buffer was never initialized.
@crtrott crtrott added the Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) label Sep 10, 2015
crtrott added a commit that referenced this issue Sep 16, 2015
@crtrott
This addresses issue #85 fixing return values of TeamPolicy reduction…
9c6af9f 
… with league_size 0

It already seemed to work for pthreads, this fixes it for OpenMP and Cuda
@crtrott
Copy link
Member Author

crtrott commented Oct 28, 2015

Pushed to master

@crtrott crtrott closed this as completed Oct 28, 2015
@crtrott crtrott self-assigned this Sep 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crtrott crtrott

Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@crtrott