Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warnings about lock_address_cuda_space #852

Closed
ibaned opened this issue May 31, 2017 · 1 comment
Closed

Warnings about lock_address_cuda_space #852

ibaned opened this issue May 31, 2017 · 1 comment
Assignees
@ibaned
Labels
Enhancement Improve existing capability; will potentially require voting
Milestone
2017-July-end

Comments

@ibaned
Copy link
Contributor

ibaned commented May 31, 2017

This issue is just here to note that the following warning shows up a lot in CUDA builds, remind me to make an attempt to fix it, and invite more experienced Kokkos devs to tell me if it can't be fixed and why.

kokkos/core/src/Kokkos_Atomic.hpp(146): warning: extern inline function "Kokkos::Impl::unlock_address_cuda_space" was referenced but not defined
kokkos/core/src/Kokkos_Atomic.hpp(134): warning: extern inline function "Kokkos::Impl::lock_address_cuda_space" was referenced but not defined
@ibaned ibaned added the Enhancement Improve existing capability; will potentially require voting label May 31, 2017
@ibaned ibaned self-assigned this May 31, 2017
@ibaned
Copy link
Contributor Author

ibaned commented May 31, 2017

put forward by @gahansen

@ibaned ibaned changed the title Warnings about lock_cuda_address_space Warnings about lock_address_cuda_space Jun 7, 2017
ibaned added a commit that referenced this issue Jun 8, 2017
@ibaned
Kokkos_Cuda_Locks drafted
02580c6 
also added to Makefile.targets
[#852]
ibaned added a commit that referenced this issue Jun 8, 2017
@ibaned
integrate and fix some bugs
866de96 
[#852]
ibaned added a commit that referenced this issue Jun 8, 2017
@ibaned
Fixed several serious bugs
b18b9e7 
[#852]
@ibaned ibaned mentioned this issue Jun 9, 2017
Merged
@ibaned ibaned modified the milestone: 2017-June-end Jun 14, 2017
@crtrott crtrott closed this as completed Jul 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ibaned ibaned

Labels
Enhancement Improve existing capability; will potentially require voting
Projects
None yet
Milestone
2017-July-end
Development

No branches or pull requests
2 participants
@ibaned @crtrott