Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calling *Space::name() causes compile error #862

Closed
ibaned opened this issue Jun 5, 2017 · 1 comment
Closed

calling *Space::name() causes compile error #862

ibaned opened this issue Jun 5, 2017 · 1 comment
Assignees
@ibaned
Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Milestone
2017-July-end

Comments

@ibaned
Copy link
Contributor

ibaned commented Jun 5, 2017

These functions were marked constexpr, but their definitions are in the .cpp files. The compiler can't evaluate a function at compile time if it can't see the definition at compile time!

The only reason this wasn't seen before is they are only ever called inside the .cpp files that contain their definition (e.g. Kokkos_HostSpace.cpp).

This is a book-keeping issue, I have a fix ready.
@ibaned ibaned added the Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) label Jun 5, 2017
@ibaned ibaned self-assigned this Jun 5, 2017
ibaned added a commit that referenced this issue Jun 5, 2017
@ibaned
Move memory space name() definitions to headers
da6286d 
see #862
@ibaned ibaned mentioned this issue Jun 5, 2017
Merged
@ibaned
Copy link
Contributor Author

ibaned commented Jun 5, 2017

#865 addresses this

@ibaned ibaned modified the milestone: 2017-June-end Jun 14, 2017
@crtrott crtrott closed this as completed Jul 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ibaned ibaned

Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Projects
None yet
Milestone
2017-July-end
Development

No branches or pull requests
2 participants
@ibaned @crtrott