Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CudaClang: Fix failing test with Clang 4.0 #941

Closed
crtrott opened this issue Jul 10, 2017 · 2 comments
Closed

CudaClang: Fix failing test with Clang 4.0 #941

crtrott opened this issue Jul 10, 2017 · 2 comments
Assignees
@crtrott
Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)

Comments

@crtrott
Copy link
Member

crtrott commented Jul 10, 2017

This is probably exposing a bug in our code, where a guaranteed warp convergence for a shuffle reduction is missing. I have a fix this is just for book keeping.
@crtrott crtrott self-assigned this Jul 10, 2017
@crtrott crtrott added the Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) label Jul 10, 2017
@crtrott
Copy link
Member Author

crtrott commented Jul 10, 2017

Also fixing the bug which was introduced with making warning go away for the lock arrays.

crtrott added a commit that referenced this issue Jul 10, 2017
@crtrott
CudaClang: fix issue #941
e37f355
@crtrott
Copy link
Member Author

crtrott commented Jul 11, 2017

Ok we have now clang 4.0 work as a Cuda compiler, assuming you have a driver 384.27 or higher loaded.

@Rombur Rombur mentioned this issue Jul 12, 2017
Closed
@crtrott crtrott closed this as completed Jul 27, 2017
@Rombur Rombur mentioned this issue Jul 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crtrott crtrott

Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@crtrott