-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure and install version file when building in Trilinos #2957
Conversation
Can one of the admins verify this patch? |
OK to test |
COMPATIBILITY SameMajorVersion) | ||
|
||
install(FILES ${CMAKE_CURRENT_BINARY_DIR}/KokkosConfigVersion.cmake | ||
DESTINATION "${${PROJECT_NAME}_INSTALL_LIB_DIR}/cmake/${PACKAGE_NAME}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bartlettroscoe please confirm this is the right way to deduce the destination
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like the correct location.
NOTE: As I mentioned here, TriBITS may need to create this file as well in order to prefer finding "standard compliant" packages.
When building inside of Trilinos, the various NOTE: We will be updating what these We are also working on a standard for these |
@bartlettroscoe this is not doing anything with KokkosConfig.cmake it only adds a Version.cmake file |
I don't have the right permissions to see that page |
@dalg24, can you contact me offline and I will see about getting you access to that site? |
@crtrott, okay. But as part of addressing TriBITSPub/TriBITS#63, we may need to write a specialized |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm that this works.
This looks fine as a fix for now. |
Another argument for Trilinos as a TPL (see TriBITSPub/TriBITS#63) and kokkos as a TPL as well. SCALE/VERA/MPACT (for example) can't use on any projects that require also require Trilinos or Kokkos. |
This is a fix to install version file to address the missing part in #2779.